Page MenuHomePhabricator

MediaWiki sets invalid Content-Encoding: none
Closed, ResolvedPublic

Description

When there are pending updates, MediaWiki::outputResponsePayload() sets a Content-Encoding: none header (added in 4f11b614).

However, "none" is not a valid Content-Encoding value. The proper value for a non-compressed output is "identity"

Event Timeline

The content encoding of 'identity', was added in rfc2616 with a note that it "SHOULD NOT be used in the Content-Encoding header". The transfer coding identity was removed by rfc7230. rfc7231 uses "identity" as a special value in the context of Accept-Encoding, not of Content-Encoding. Anyway, the semantics of a Content-encoding: identity are completely clear and supported even if it may make for a redundant header.

Change 616313 had a related patch set uploaded (by Nikerabbit; owner: Platonides):
[mediawiki/core@master] Change invalid 'Content-Encoding: none' header

https://gerrit.wikimedia.org/r/616313

Change 616313 merged by jenkins-bot:
[mediawiki/core@master] Change invalid 'Content-Encoding: none' header

https://gerrit.wikimedia.org/r/616313

Change 641776 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Platonides):
[mediawiki/core@REL1_35] Change invalid 'Content-Encoding: none' header

https://gerrit.wikimedia.org/r/641776

Change 641776 merged by jenkins-bot:
[mediawiki/core@REL1_35] Change invalid 'Content-Encoding: none' header

https://gerrit.wikimedia.org/r/641776