Page MenuHomePhabricator
Create Task
Maniphest T251642

Make Special:Version/License support multiple license files in a repo
Closed, ResolvedPublic
Actions

Description

Special:Version/License only displays one file from a repo.. When it's possible for a repo to have many as per https://spdx.org/ids-how (AND OR etc)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow extensions (et al) to have multiple LICENSE/COPYING filesmediawiki/coremaster+61 -28
tests: Add test file to test SPDX license expressionsmediawiki/coremaster+9 -0
[WIP] registration: Allow arrays for license-namemediawiki/coremaster+30 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.May 1 2020, 8:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2020, 8:24 PM
Reedy mentioned this in T251643: Clarify license of Universal Language Selector.May 1 2020, 8:26 PM
gerritbot added a comment.May 1 2020, 8:29 PM

Change 593813 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] [WIP] registration: Allow arrays for license-name

https://gerrit.wikimedia.org/r/593813

gerritbot added a project: Patch-For-Review.May 1 2020, 8:29 PM
Reedy mentioned this in T234086: Missing detailed license info on enwiki.May 1 2020, 9:03 PM
Nikerabbit subscribed.May 2 2020, 6:54 AM

Seems redundant with the inline syntax: https://spdx.org/ids-how

Reedy added a comment.May 2 2020, 11:28 AM
In T251642#6101868, @Nikerabbit wrote:

Seems redundant with the inline syntax: https://spdx.org/ids-how

Curious. If that’s the case, does MW actually support it? I’m guessing not?

gerritbot added a comment.May 2 2020, 11:34 AM

Change 593813 abandoned by Reedy:
[WIP] registration: Allow arrays for license-name

https://gerrit.wikimedia.org/r/593813

Reedy added a comment.May 2 2020, 11:35 AM
In T251642#6102021, @Reedy wrote:
In T251642#6101868, @Nikerabbit wrote:

Seems redundant with the inline syntax: https://spdx.org/ids-how

Curious. If that’s the case, does MW actually support it? I’m guessing not?

I mean the parsing out/splitting etc...

Reedy renamed this task from Allow license-name to take an array of SPDX identifier strings to Improve license-name support of SPDX license expressions.May 2 2020, 11:39 AM
Reedy removed a project: Patch-For-Review.
gerritbot added a comment.May 2 2020, 11:46 AM

Change 593895 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] tests: Add test file to test SPDX license expressions

https://gerrit.wikimedia.org/r/593895

gerritbot added a project: Patch-For-Review.May 2 2020, 11:46 AM
gerritbot added a comment.May 2 2020, 12:32 PM

Change 593901 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Allow extensions (et al) to have multiple LICENSE/COPYING files

https://gerrit.wikimedia.org/r/593901

Reedy added a comment.May 2 2020, 12:34 PM
In T251642#6102116, @gerritbot wrote:

Change 593901 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Allow extensions (et al) to have multiple LICENSE/COPYING files

https://gerrit.wikimedia.org/r/593901

Is it worth some sort of header/title between the licenses?

Screenshot 2020-05-02 at 13.32.37.png (476×2 px, 153 KB)

Obviously one would go at the top too...

Would the filename suffice? In this case == MIT-COPYING ==

Reedy renamed this task from Improve license-name support of SPDX license expressions to Make Special:Version/License support multiple license files in a repo.May 2 2020, 12:58 PM
Reedy edited projects, added MediaWiki-Special-pages; removed MediaWiki-Configuration.
Reedy updated the task description. (Show Details)
Reedy added parent tasks: T234086: Missing detailed license info on enwiki, T251649: Missing detailed license info on WMF deployed extensions.May 4 2020, 1:40 PM
gerritbot added a comment.May 5 2020, 1:29 AM

Change 593895 merged by jenkins-bot:
[mediawiki/core@master] tests: Add test file to test SPDX license expressions

https://gerrit.wikimedia.org/r/593895

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 5 2020, 8:01 AM
Reedy mentioned this in T251649: Missing detailed license info on WMF deployed extensions.May 6 2020, 12:37 AM
gerritbot added a comment.May 6 2020, 10:06 PM

Change 593901 merged by jenkins-bot:
[mediawiki/core@master] Allow extensions (et al) to have multiple LICENSE/COPYING files

https://gerrit.wikimedia.org/r/593901

Reedy closed this task as Resolved.May 6 2020, 10:07 PM
Reedy claimed this task.
Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 10:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 6 2020, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits