Consider making CSP header be sent after onBeforePageDisplay hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Mar 2 2020, 8:48 AM

Description

Right now, CSP headers are calculated and sent before the BeforePageDisplay hook. This means that if you add some module in the onBeforePageDisplay hook (which is very common) you cannot adjust the CSP header in the same hook. This makes things rather cumbersome. Maybe we should adjust the CSP header to happen after that hook.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow adjusting CSP headers from BeforePageDisplay hook	mediawiki/core	master	+4 -3

Customize query in gerrit

Event Timeline

Bawolff created this task.Mar 2 2020, 8:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2020, 8:48 AM

Change 575981 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/core@master] Allow adjusting CSP headers from BeforePageDisplay hook

https://gerrit.wikimedia.org/r/575981

gerritbot added a project: Patch-For-Review.Mar 2 2020, 9:15 AM

Aklapper added a project: MediaWiki-General.Mar 2 2020, 9:50 AM

Change 575981 merged by jenkins-bot:
[mediawiki/core@master] Allow adjusting CSP headers from BeforePageDisplay hook

https://gerrit.wikimedia.org/r/575981

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2020, 2:10 AM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 2:59 PM

Jdforrester-WMF closed this task as Resolved.Mar 5 2020, 6:08 PM

Jdforrester-WMF assigned this task to Bawolff.