Page MenuHomePhabricator

Align center column margins to be consistent
Closed, ResolvedPublic

Description

All sections in the center column should have 20px margin to the left and right. Together with the 20px padding from the modal this should result of 40px distance of the section content to the left or right modal border.

image.png (990×1 px, 97 KB)

See figma: https://www.figma.com/file/KIkcQ7NjOl8OkQtGWe5duIbW/Wikidata-Bridge?node-id=2840%3A2

AC

  • the following sections have the full with and 40px distance to the left and right modal border:
    • main snak input area
    • references section
    • edit decision section

Notes

  • input label spacing will be reworked in the story for the view history link

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 567007 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Make center column side margins more consistent

https://gerrit.wikimedia.org/r/567007

Change 567007 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Make center column side margins more consistent

https://gerrit.wikimedia.org/r/567007

@Michael looks good! i have a question about the margin at the bottom though. there seems to be a little gap that i don't remember being there before. Do you know what's causing this?

image.png (183×549 px, 18 KB)

Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-12 board.

i checked with lucas, this seems to be normal. moving it to done!