HTML entity is shown as a raw text in mobile version
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MBH
	Jan 23 2020, 11:26 AM

Description

See

Screenshot_20200123-170339.png (1×1 px, 204 KB)

on page https://ru.m.wikipedia.org/wiki/user:MBH?uselang=ru . This message is on https://translatewiki.net/wiki/MediaWiki:Minerva-page-actions-info/ru page.

QA Results

AC	Status	Details
1	✅	T243502#5841651

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Escape HTML in toolbar menu	mediawiki/skins/MinervaNeue	master	+2 -2

Customize query in gerrit

Event Timeline

MBH created this task.Jan 23 2020, 11:26 AM

Restricted Application added subscribers: Masumrezarock100, Base, Aklapper. · View Herald TranscriptJan 23 2020, 11:26 AM

Ammarpad subscribed.Jan 23 2020, 12:37 PM

Masumrezarock100 closed this task as a duplicate of T236711: It should be possible to customise the implementation of mw.util.addPortletLink function on a skin basis.Jan 23 2020, 1:42 PM

Nevermind. I thought they were referring to addPortletLink styling problem. Sorry for the confusion.

I have updated the translation on translatewiki. We just need to wait until the change get merged, I suppose.

Masumrezarock100 edited projects, added I18n; removed MediaWiki-User-Interface, MobileFrontend.Jan 23 2020, 1:50 PM

In T243502#5826778, @Masumrezarock100 wrote:

I have updated the translation on translatewiki. We just need to wait until the change get merged, I suppose.

Updating the translation doesn’t fix the problem with bad Unicode handling though, and non-breaking space that you removed on Translatewiki was useful there.

In T243502#5826995, @stjn wrote:

In T243502#5826778, @Masumrezarock100 wrote:

I have updated the translation on translatewiki. We just need to wait until the change get merged, I suppose.

Updating the translation doesn’t fix the problem with bad Unicode handling though, and non-breaking space that you removed on Translatewiki was useful there.

Hmm, good point. I didn't think about the nbsp. Feel free to revert my change there or we can just wait until we fix this.

.........
I could replace this character on my own. But the problem isn't this character, but that some software replaces Unicode character "nbsp" with HTML entity and doesn't show this entity as "nbsp", but shows it as a raw text.

Change 566929 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Escape HTML in User namespace toolbar menu

https://gerrit.wikimedia.org/r/566929

gerritbot added a project: Patch-For-Review.Jan 24 2020, 6:25 AM

Ammarpad triaged this task as Medium priority.Jan 24 2020, 6:29 AM

Jdlrobson added a project: Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3).Jan 27 2020, 2:18 AM

Masumrezarock100 moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.Jan 27 2020, 2:24 AM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.Jan 28 2020, 8:33 AM

Ammarpad claimed this task.Jan 28 2020, 2:26 PM

Jdlrobson reassigned this task from Ammarpad to Edtadros.Jan 29 2020, 5:13 AM

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.

Change 566929 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Escape HTML in toolbar menu

https://gerrit.wikimedia.org/r/566929

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 29 2020, 6:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2020, 6:10 AM

Masumrezarock100 updated the task description. (Show Details)Jan 29 2020, 8:21 AM

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

✅ AC1: On page https://ru.m.wikipedia.org/wiki/user:MBH?uselang=ru validate that HTML entity is not shown as a raw text on the in the overflow menu on the mobile version

ru.m.wikipedia.org_wiki_user_MBH_uselang=ru(iPhone X) (1).png (2×1 px, 323 KB)

Edtadros updated the task description. (Show Details)Jan 31 2020, 12:00 PM

The QA steps are wrong. This change hasn't deployed to production wikis yet. Use beta cluster instead. The correct URL would be https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson?uselang=ru. Seems fixed though.

Screenshot_20200131-190340.png (480×960 px, 37 KB)

Resolving based on beta cluster results

	F31541906: Screenshot_20200131-190340.png
	Jan 31 2020, 1:34 PM

	F31541825: ru.m.wikipedia.org_wiki_user_MBH_uselang=ru(iPhone X) (1).png
	Jan 31 2020, 11:59 AM

	F31522439: Screenshot_20200123-170339.png
	Jan 23 2020, 11:26 AM

HTML entity is shown as a raw text in mobile versionClosed, ResolvedPublicActions