Replace direct access to MediaWikiServices with injected converter;
$converter = MediaWikiServices::getInstance()->getLanguageConverterFactory() ->getLanguageConverter( $this->contLang );
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | roman-stolar | T226832 Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends | |||
| Resolved | Peter.ovchyn | T226833 Introduce LanguageConverterFactory service | |||
| Resolved | Peter.ovchyn | T243321 Inject LanguageConverter via DI DefaultPreferencesFactory |
Event Timeline
Comment Actions
DefaultPreferencesFactory is already using DI and is constructed in ServiceWiring.php. Injecting should be trivial.
Oh right, the complication is that GlobalPreferencesFactory extends DefaultPreferencesFactory. So introducing a new parameter to the constructor requires at least three patches.
Comment Actions
Change 569028 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] parser: Inject a LanguageConverterFactory through ParserFactory into class Parser
Comment Actions
Change 569312 had a related patch set uploaded (by Peter.ovchyn; owner: Peter Ovchinnikov):
[mediawiki/extensions/GlobalPreferences@master] language: Inject LanguageConverter via DI DefaultPreferencesFactory
Comment Actions
Change 569936 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] parser: Inject a LanguageConverterFactory through DI containers: Add braking changes into DefaultPreferencesFactory
Comment Actions
Change 569028 merged by jenkins-bot:
[mediawiki/core@master] parser: Inject a LanguageConverterFactory through DI containers:
Comment Actions
Change 569312 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] language: Inject LanguageConverter via DI into DefaultPreferencesFactory
Comment Actions
Change 569936 merged by jenkins-bot:
[mediawiki/core@master] parser: Inject a LanguageConverterFactory through DI containers: Add braking changes into DefaultPreferencesFactory