ObjectFactory.php on line 172
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.15

message

Argument 4 passed to WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::newFromGlobalState() must be an instance of WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker, instance of WikibaseQuality\ConstraintReport\Api\CachingResultsSource given, called in /srv/mediawiki/php-1.35.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php on line 172

Impact

There are this point four instance of this on group0 wikis, all within the last hour. This doesn't seem too bad, but I'm worried there might be an explosion of this in group1 or group2.

Notes

Details

Request ID: Xh8AowpAADkAAJLPK54AAADV
Request URL: https://test.wikidata.org/wiki/Special:SpecialPages

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php(172): WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::newFromGlobalState(GlobalVarConfig, BufferingStatsdDataFactory, Wikibase\DataModel\Services\Lookup\ExceptionIgnoringEntityLookup, WikibaseQuality\ConstraintReport\Api\CachingResultsSource)
#1 /srv/mediawiki/php-1.35.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php(102): Wikimedia\ObjectFactory::getObjectFromSpec(array, array)
#2 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(447): Wikimedia\ObjectFactory->createObject(array, array)
#3 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(478): MediaWiki\Special\SpecialPageFactory->getPage(string)
#4 /srv/mediawiki/php-1.35.0-wmf.15/includes/specials/SpecialSpecialpages.php(56): MediaWiki\Special\SpecialPageFactory->getUsablePages(User)
#5 /srv/mediawiki/php-1.35.0-wmf.15/includes/specials/SpecialSpecialpages.php(44): SpecialSpecialpages->getPageGroups()
#6 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPage.php(575): SpecialSpecialpages->execute(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(967): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(530): MediaWiki->main()
#11 /srv/mediawiki/php-1.35.0-wmf.15/index.php(46): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix service injection for special page	mediawiki/extensions/WikibaseQualityConstraints	wmf/1.35.0-wmf.15	+1 -1
	Fix service injection for special page	mediawiki/extensions/WikibaseQualityConstraints	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEBQC81bf5b0a5f87: Fix service injection for special page
rEBQCbf7ff34060c1: Fix service injection for special page
T242856: PHP Warning: Invalid argument supplied for foreach()

Event Timeline

• LarsWirzenius created this task.Jan 15 2020, 12:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 12:17 PM

Oops, I might have messed up the service wiring.

(The special page is very rarely used, so it’s entirely plausible that it crashes on each request and still barely makes a blip in logstash.)

I’m not sure why @gerritbot isn’t leaving a comment, but patch is up: https://gerrit.wikimedia.org/r/564977 (will need to be backported too).

Right. There's now 20 occurences.

My understanding of your comment is that it's not a sufficient problem to block the train, and that you have a fix. The fix can be deployed next week or in SWAT, I assume.

Aklapper added a project: Wikibase-Quality-Constraints.Jan 15 2020, 12:53 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 15 2020, 12:53 PM

Aklapper added a project: Patch-For-Review.Jan 15 2020, 12:54 PM

Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jan 15 2020, 12:54 PM

Yup, the fix is straightforward (if I don’t find a reviewer I think a self-merge is acceptable here) and I can backport it soon.

Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 15 2020, 12:55 PM

• Pablo-WMDE subscribed.Jan 15 2020, 1:07 PM

Thanks, Lucas.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 15 2020, 1:15 PM

Change 565012 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.15] Fix service injection for special page

https://gerrit.wikimedia.org/r/565012

• brennen added a project: User-brennen.Jan 15 2020, 2:59 PM

• brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Ladsgroup mentioned this in T242856: PHP Warning: Invalid argument supplied for foreach().Jan 15 2020, 3:09 PM

Addshore merged a task: T242865: Internal error on Wikidata's Special:SpecialPages.Jan 15 2020, 3:32 PM

Addshore added subscribers: abian, Addshore.

Change 564977 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix service injection for special page

https://gerrit.wikimedia.org/r/564977

Lucas_Werkmeister_WMDE mentioned this in rEBQCbf7ff34060c1: Fix service injection for special page.Jan 15 2020, 3:41 PM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 15 2020, 3:45 PM

Change 565012 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.15] Fix service injection for special page

https://gerrit.wikimedia.org/r/565012

Lucas_Werkmeister_WMDE mentioned this in rEBQC81bf5b0a5f87: Fix service injection for special page.Jan 15 2020, 3:50 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-15T15:54:59Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/extension.json: [[gerrit:565012|Fix service injection for special page (T242846)]] (duration: 01m 08s)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 15 2020, 4:00 PM

Ladsgroup closed this task as Resolved.Jan 15 2020, 4:01 PM

Ladsgroup moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.