Page MenuHomePhabricator
Create Task
Maniphest T241354

Drop support for passing a User to ApiBase::checkTitleUserPermissions, deprecated and unused
Closed, ResolvedPublic
Actions

Description

ApiBase::checkTitleUserPermissions has no remaining calls that have the third parameter as a user, and backwards-compatibility for this can be removed
Code search: https://codesearch.wmflabs.org/search/?q=checkTitleUserPermissions&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop support for passing a User to ApiBase::checkTitleUserPermissionsDannyS712mediawiki/coremaster+7 -6
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 23 2019, 8:37 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 23 2019, 8:37 AM
Restricted Application added a subscriber: • Aklapper. · View Herald Transcript
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Dec 23 2019, 8:40 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Dec 28 2019, 5:08 AM
gerritbot added a comment.Jan 8 2020, 7:19 PM

Change 562917 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Drop support for passing a User to ApiBase::checkTitleUserPermissions

https://gerrit.wikimedia.org/r/562917

gerritbot added a project: Patch-For-Review.Jan 8 2020, 7:19 PM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Jan 8 2020, 7:21 PM
Florian closed this task as Resolved.Jan 24 2020, 5:31 PM
Florian removed a project: Patch-For-Review.
gerritbot added a comment.Jan 24 2020, 5:52 PM

Change 562917 merged by jenkins-bot:
[mediawiki/core@master] Drop support for passing a User to ApiBase::checkTitleUserPermissions

https://gerrit.wikimedia.org/r/562917

Jdforrester-WMF added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 1:15 AM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 6 2020, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits