Preferences are saved as GlobalPreferences when autoglobal is enabled for the field
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• dmaza
	Nov 6 2019, 1:36 PM

Project Tags

Referenced Files

None

Subscribers

Description

Background

Based on the T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption we decided that if a preference is local for the user (the user does not have that preference enabled in Special:GlobalPreferences) then the value will be saved locally.

In T224245#5225203, @Mooeypoo wrote:

Here's what I thought we agreed to (correct me if I'm wrong) --

If the setting is whitelisted (in however manner we do that, based on your first bulletpoint) GlobalPreferences will check and act according to:

If, for the user, the setting is not global -> save in local

If, for the user, the setting is global -> save in global

If, for the user, the setting is global *but* uses local override -> save in local override.

Basically, GlobalPreferences knows where the setting is actually active for the user, and wherever it is active, it will save it to.

But that is not what happens right now.

Steps to reproduce

Enable autoglobal for the setting and other relevant flags

	$wgGlobalPreferencesAutoPrefs = [
		'email-blacklist',
	];
        $wgEnableUserEmailBlacklist = true;
        $wgEnableSpecialMute = true;

Make sure you don't have Prohibit these users from emailing me as a global preference.
Go to Special:Mute/some-user (Make sure your user has a confirmed email address)
Mute user from sending you emails

Expected behavior: Option is saved locally.
Actual behavior: GlobalPreferences auto-enables Prohibit these users from emailing me

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix preferences in $wgGlobalPreferencesAutoPrefs always saving as global	Dmaza	mediawiki/extensions/GlobalPreferences	master	+26 -16

Customize query in gerrit

Related Objects

Mentioned In: T231577: Deploy Special:Mute features
Mentioned Here: T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption

Event Timeline

• dmaza created this task.Nov 6 2019, 1:36 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 6 2019, 1:36 PM

Restricted Application added a subscriber: • Aklapper. · View Herald Transcript

• Niharika added a project: Anti-Harassment-Team.Nov 6 2019, 8:02 PM

Restricted Application added a subscriber: MGChecker. · View Herald TranscriptNov 6 2019, 8:02 PM

@MaxSem @Mooeypoo @ifried Flagging this for you all.
For context, @ifried, this task is a bug from T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption that Max worked on. It's for an extension that CommTech worked on last year. This bug is a blocker for one of Anti-Harassment-Team tools team's ongoing projects so I'm hoping we can get it fix soon.

• dmaza mentioned this in T231577: Deploy Special:Mute features.Nov 14 2019, 9:11 PM

• Niharika updated the task description. (Show Details)Nov 22 2019, 7:53 PM

• dmaza claimed this task.Jan 2 2020, 9:50 PM

• dmaza moved this task from Tracking work by others to The Letter Song on the Anti-Harassment-Team board.

• dmaza edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.

• dmaza moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

Change 563590 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/GlobalPreferences@master] Fix preferences in $wgGlobalPreferencesAutoPrefs always saving as global

https://gerrit.wikimedia.org/r/563590

gerritbot added a project: Patch-For-Review.Jan 10 2020, 10:06 PM

• dmaza moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jan 13 2020, 7:14 PM

Change 563590 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Fix preferences in $wgGlobalPreferencesAutoPrefs always saving as global

https://gerrit.wikimedia.org/r/563590

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2020, 6:10 PM

MaxSem unsubscribed.Jan 15 2020, 6:21 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 15 2020, 7:00 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Jan 15 2020, 8:51 PM

• Niharika triaged this task as Medium priority.Jan 16 2020, 8:01 PM

If, for the user, the setting is not global -> save in local
If, for the user, the setting is global -> save in global
If, for the user, the setting is global *but* uses local override -> save in local override.

Repeated these three use cases for option email-blacklist (which is in $wgGlobalPreferencesAutoPrefs) and requireemail (which is not).

For email-blacklist, I tested setting the option from Special:Mute and via the API. For requireemail, just via the API.

In the database I looked at the values of those options in enwiki.user_properties (where local properties are stored) and centralauth.global_preferences (where global properties are stored).

I compared the values of local and global before and after setting the option to see if the behaviour is correct.

Where both global and local values are set, global takes precedence (unless there is a local override). Where there is no global value in the database, there is no global preference for that option.

#	$wgGlobalPreferencesAutoPrefs	Global	Local override	Outcome
1	Yes	Yes	No	Local and global are set to same the value
2	Yes	Yes	Yes	Local value changed; Global value not changed
3	Yes	No	N/A	Local value changed; no global value in DB
4	No	Yes	No	Local value changed; Global value not changed
5	No	Yes	Yes	Local value changed; Global value not changed
6	No	No	N/A	Local value changed; no global value in DB

The difference is in row 3. Now, when the option is set locally it does not save the option as a global preference.

Testing Environment: https://en.wikipedia.beta.wmflabs.org

Thanks Dom!

Preferences are saved as GlobalPreferences when autoglobal is enabled for the fieldClosed, ResolvedPublicBUG REPORTActions