Decide minimum supported PHP version for next MLEB release
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Oct 11 2019, 7:26 AM

Description

Currently we claim to support PHP 7.0.0 and above. https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle

MediaWiki 1.34 will require PHP 7.2.9 or above.

Our options are either keep it 7.0.0 until MediaWiki 1.35 is released, or already increase it to 7.2.

Keeping 7.0 support will be hard unless we find a way to enforce it via linters and automatic testing with that PHP versions. We should only do it if we can reasonable guarantee that it actually keeps working.

7.2 allows to use some new features, but nothing very significant. We automatically get testing on it and know it will work well.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	build: Explicitly require PHP >= 7.2, per MLEB 2020.01 baseline	mediawiki/extensions/Translate	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		KartikMistry	T236167 Release MLEB 2019.10
		Resolved		abi_	T235249 Decide minimum supported PHP version for next MLEB release

Event Timeline

Nikerabbit created this task.Oct 11 2019, 7:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2019, 7:26 AM

Nikerabbit moved this task from Backlog to 2019.10 on the MediaWiki Language Extension Bundle board.Oct 11 2019, 8:42 AM

Translate is already incompatible in tests with 7.0, requires 7.1 after @MaxSem merged da6bfe8 due to void return type introduced in 7.1. A compromise would be to require 7.1 instead.

abi_ subscribed.Oct 12 2019, 11:55 AM

Another few reasons to go with PHP 7.1,

Currently we are using Mediawiki Phan - 0.7.1, but if we upgrade to 0.8.0, we'll need PHP 7.2 (https://github.com/wikimedia/mediawiki-tools-phan/blob/master/composer.json#L13). This was already discussed on Gerrit on Change Id: I21251df7c5d45f0c803556b4bc4b7947f30d7cc1
That patch (11bcb52dc61a) also introduces nullable types, which requires PHP 7.1
PHP 7.0 has reached EOL

I think with this release we can go with PHP 7.1, in line with official PHP support. For the next MLEB release in Jan, 2020 we can bump up the minimum version to 7.2, in line with official PHP releases.

Nikerabbit added a parent task: T236167: Release MLEB 2019.10.Oct 22 2019, 2:14 PM

abi_ mentioned this in T236956: PHP Fatal error: Can't inherit abstract function on marking page for translation in PHP 7.1.33.Oct 30 2019, 8:43 PM

As per discussion with Niklas, we've decided to keep the minimum PHP version for the current MLEB release as 7.1 and planning to make it 7.2 for the next release.

Ricordisamoa subscribed.Dec 24 2019, 12:59 PM

Change 565812 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] build: Explicitly require PHP >= 7.2, per MLEB 2020.01 baseline

https://gerrit.wikimedia.org/r/565812

gerritbot added a project: Patch-For-Review.Jan 20 2020, 6:32 AM

Change 565812 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] build: Explicitly require PHP >= 7.2, per MLEB 2020.01 baseline

https://gerrit.wikimedia.org/r/565812

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 20 2020, 5:00 PM