Page MenuHomePhabricator
Create Task
Maniphest T164453

How to switch off new heading/section HTML div-split function
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Hello.
We are using VisualEditor in nested div tags and find it very disturbing that when a new heading is created the HTML elements are split (VE closes all the open HTML elements and opens new ones after the heading). We were searching for this function in the code so we can disable it, but weren't able to locate it. Any help in locating the function (function name, relevant files, etc.) will be very helpful.
Thanks!

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow headings in divsmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Event Timeline

Wess created this task.May 4 2017, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2017, 8:03 AM
gerritbot subscribed.May 4 2017, 11:44 AM

Change 351818 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Allow headings in divs

https://gerrit.wikimedia.org/r/351818

gerritbot added a project: Patch-For-Review.May 4 2017, 11:44 AM
Jdforrester-WMF assigned this task to Esanders.May 4 2017, 6:40 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF subscribed.

@Wess: Is this for VisualEditor inside a MediaWiki environment, or in stand-alone VisualEditor?

gerritbot added a comment.May 4 2017, 6:49 PM

Change 351818 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Allow headings in divs

https://gerrit.wikimedia.org/r/351818

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 4 2017, 7:00 PM
Wess added a comment.EditedMay 5 2017, 7:26 AM
In T164453#3236560, @Jdforrester-WMF wrote:

@Wess: Is this for VisualEditor inside a MediaWiki environment, or in stand-alone VisualEditor?

Inside MW MediaWiki environments.
The patch indeed solved the issue. Thank you!

Jdforrester-WMF closed this task as Resolved.May 8 2017, 5:54 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 8 2017, 5:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits