Page MenuHomePhabricator
Create Task
Maniphest T164199

Transclusion table cells: editing transclusion causes error about mergeable cells
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

image.png (312×876 px, 42 KB)

TypeError: selection.isMergeable is not a function at VeUiMergeCellsContextItem.ve.ui.MergeCellsContextItem.setup (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contextitems/ve.ui.MergeCellsContextItem.js?82ffd:56:27) at VeUiDesktopContext.ve.ui.Context.setupMenuItems (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/ve.ui.Context.js?b3717:160:14) at VeUiDesktopContext.ve.ui.LinearContext.afterContextChange (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contexts/ve.ui.LinearContext.js?4f225:118:10) at VeUiDesktopContext.ve.ui.DesktopContext.afterContextChange (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contexts/ve.ui.DesktopContext.js?07a30:74:58)

i.e. isMergeable = selection.isMergeable();

...and then it changes the context item to look like this:

image.png (412×874 px, 37 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (3b8a164a3)mediawiki/extensions/VisualEditormaster+2 -1
MergeCellsContextItem: Make sure we're on a TableSelectionVisualEditor/VisualEditormaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.May 1 2017, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2017, 3:38 PM
DLynch added a project: VisualEditor.May 1 2017, 3:38 PM
gerritbot subscribed.May 1 2017, 4:01 PM

Change 351157 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] MergeCellsContextItem: Make sure we're on a TableSelection

https://gerrit.wikimedia.org/r/351157

gerritbot added a project: Patch-For-Review.May 1 2017, 4:01 PM
gerritbot added a comment.May 1 2017, 5:53 PM

Change 351157 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MergeCellsContextItem: Make sure we're on a TableSelection

https://gerrit.wikimedia.org/r/351157

Jdforrester-WMF closed this task as Resolved.May 1 2017, 5:54 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added VisualEditor-Tables; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 1 2017, 5:54 PM
gerritbot added a comment.May 1 2017, 6:32 PM

Change 350859 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3b8a164a3)

https://gerrit.wikimedia.org/r/350859

gerritbot added a project: Patch-For-Review.May 1 2017, 6:32 PM
gerritbot added a comment.May 1 2017, 9:30 PM

Change 350859 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3b8a164a3)

https://gerrit.wikimedia.org/r/350859

Jdforrester-WMF removed a project: Patch-For-Review.May 1 2017, 9:31 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 1 2017, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits