Page MenuHomePhabricator
Create Task
Maniphest T164016

Tables can be created inside list items, even though that is invalid wikitext
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Specify suggested parent node types for tablesmediawiki/extensions/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Apr 27 2017, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2017, 5:20 PM
Jdforrester-WMF subscribed.Apr 27 2017, 5:22 PM

Eh. * <table><tr><td>Foo</td><td>Bar</td></tr></table> is valid wikitext and renders fine. Parsoid needs to not try to serialise it to wikitext-style…

Esanders added a subtask: T164017: Enforce suggestedParentNodeTypes in fixupInsertion.Apr 27 2017, 5:28 PM

So is * <h2>Heading</h2>. This is why we have suggestedParentNodeTypes. It allows it to exist in the document, but prevents the user from creating it because they probably don't want to.

gerritbot subscribed.Apr 27 2017, 5:35 PM

Change 350609 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Specify suggested parent node types for tables

https://gerrit.wikimedia.org/r/350609

gerritbot added a project: Patch-For-Review.Apr 27 2017, 5:35 PM
Jdforrester-WMF assigned this task to Esanders.May 2 2017, 7:18 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF changed the task status from Open to Stalled.May 4 2017, 6:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Config written and merged, but workingness blocked by child.

gerritbot added a comment.May 4 2017, 6:50 PM

Change 350609 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Specify suggested parent node types for tables

https://gerrit.wikimedia.org/r/350609

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 4 2017, 7:00 PM
Esanders merged a task: T166343: VE insert table conflict with unordered list not obvious to user.May 25 2017, 9:21 PM
Esanders added subscribers: Jamesmontalvo3, matmarex.
Jdforrester-WMF closed subtask T164017: Enforce suggestedParentNodeTypes in fixupInsertion as Resolved.Jun 29 2017, 7:29 AM
matmarex added a parent task: T57746: Multiline list items rendering differently in ContentEditable than the resulting wikitext.Jan 29 2020, 7:52 PM
matmarex closed this task as Resolved.Jun 14 2021, 12:07 PM
In T164016#3236572, @Jdforrester-WMF wrote:

Config written and merged, but workingness blocked by child.

Looks like the child (subtask) has been resolved in 2017.

matmarex merged a task: T147348: It's possible to insert a table inside a definition list, which breaks the formatting in edit mode and is incorrectly serialized by Parsoid.Jun 14 2021, 12:07 PM
matmarex added a subscriber: jhsoby.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits