Description

Validation is fragile and responsibility is spread out among classes. Take a small clean-up step, with these acceptance criteria:

Gateway adapter class has the sole responsibility for defining and running validations.
Drop distinctions between error types, e.g. manual and validation errors.
Changed code must be completely covered by tests.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Only check for required fields in do_transaction	mediawiki/extensions/DonationInterface	master	+53 -26
	Deprecate "manual" errors and shift responsibility for validation into the adapter	mediawiki/extensions/DonationInterface	master	+220 -270

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T160385 [Tech Debt] Consolidate DonationInterface validation
					Restricted Task

Event Timeline

awight created this task.Mar 13 2017, 11:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2017, 11:11 PM

Change 341727 had a related patch set uploaded (by Awight):
[mediawiki/extensions/DonationInterface] Deprecate "manual" errors and shift responsibility for validation into the adapter

https://gerrit.wikimedia.org/r/341727

gerritbot added a project: Patch-For-Review.Mar 13 2017, 11:11 PM

awight moved this task from Backlog to Review on the Fundraising Sprint English Cuisine board.Mar 13 2017, 11:11 PM

awight set the point value for this task to 2.

awight updated the task description. (Show Details)

awight created subtask Restricted Task.Mar 13 2017, 11:27 PM

The form is prematurely validating, and T159910 lies in the path of forward progress...

awight moved this task from Review to Doing on the Fundraising Sprint English Cuisine board.Mar 13 2017, 11:37 PM

• DStrine moved this task from Triage to Current Sprint and Completed in Q3 2016-17 on the Fundraising-Backlog board.Mar 14 2017, 7:23 PM

• DStrine added a project: Fundraising Sprint Far Beer.Mar 15 2017, 10:42 PM

Aww, this work is at risk of going stale. Let's decide if we want the changes, and I'll spend a few days getting it over the bar.

• DStrine added a project: Fundraising Sprint Gondwanaland Reunification Engine.Mar 29 2017, 10:48 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Gondwanaland Reunification Engine board.Mar 30 2017, 7:02 PM

• DStrine added a project: Fundraising Sprint Homebrew Hadron Collider.Apr 12 2017, 10:40 PM

• DStrine moved this task from Current Sprint and Completed in Q3 2016-17 to Completed in Q4 2016-17 on the Fundraising-Backlog board.Apr 14 2017, 10:26 PM

• DStrine reassigned this task from awight to Ejegg.Apr 26 2017, 10:31 PM

• DStrine added a project: Fundraising Sprint Ivory Tower Defense Games.Apr 26 2017, 10:50 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Ivory Tower Defense Games board.Apr 26 2017, 11:22 PM

Change 350462 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Only check for required fields in do_transaction

https://gerrit.wikimedia.org/r/350462

Change 341727 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Deprecate "manual" errors and shift responsibility for validation into the adapter

https://gerrit.wikimedia.org/r/341727

Change 350462 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Only check for required fields in do_transaction

https://gerrit.wikimedia.org/r/350462

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 27 2017, 11:00 PM

• DStrine added a project: Fundraising Sprint Judgement Suspenders.May 10 2017, 10:56 PM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Judgement Suspenders board.May 11 2017, 7:31 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Judgement Suspenders board.May 17 2017, 7:50 PM

Ejegg closed this task as Resolved.May 23 2017, 6:11 PM

Ejegg reassigned this task from Ejegg to awight.

Ejegg triaged this task as Medium priority.

Ejegg subscribed.

• mmodell removed a subscriber: awight.Jun 22 2017, 9:32 PM