Start adding tests for all types of notifications
Status:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Etonkovidova | T146916 RSpec tests for Echo notifications | |||
| Declined | None | T164479 mwext-ruby-jessie Jenkins job runs all Ruby tasks for MediaWiki extensions | |||
| Declined | None | T171753 Create a Jenkins job that runs Echo RSpec tests daily |
Change 313221 had a related patch set uploaded (by Etonkovidova):
WIP RSpec test for Mention notificationon
Change 324687 had a related patch set uploaded (by Zfilipin):
WIP RSpec tests for Echo Mention notificationon
Change 327219 had a related patch set uploaded (by Zfilipin):
WIP mwext-mw-rspec-jessie does not need Vector skin
Change 348721 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] [WIP] RSpec tests for mention notification
I can not run tests locally because of T161140: Ruby::Bundle fails on Jessie MediaWiki-Vagrant.
Change 348761 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify a new user with welcome message
Change 348721 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Echo should notify a new user with welcome message
Change 313221 abandoned by Zfilipin:
[WIP] RSpec tests for mention notification
Reason:
I have split this commit into several smaller ones:
https://gerrit.wikimedia.org/r/#/q/topic:T146916
Smaller commits should be easier to merge.
Change 348761 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Echo should notify user about mention on wikitext page
I have been talking about this rspec suite for Echo with Zeljko.
Looking at tests/rspec/notification_spec.rb, it does http query to api.php with parameters, grab the result and runs assertion on it.
We already have support to test the API in MediaWiki / PHPUnit . There are even some in Echo already in tests/phpunit/api/ApiEchoNotificationsTest.php (written by Benny Situ back in 2014).
I highly recommend to extend the PHPUnit tests instead of introducing a new stack based on ruby/rspec. The only advantage the spec has right now, is that one can potentially target an arbitrary URL. Maybe that was the intent ?
Additional note: the advantage of the rspec based tests is that they are super fast and do not use a browser. So that is a good fast smoke test to run before running the actual browser tests. I am not sure using ruby/rspec is a best stack long term, but right now it is good enough (and code is already there).
Change 348775 had a related patch set uploaded (by Etonkovidova; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify user about new edits on user talk page
Change 348774 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify a user who watches a Flow board when another user creates a new topic there
Change 348769 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify an author of a Flow topic when another user posts a reply
Change 348764 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify new user about Flow mention on Flow talk page
Change 348768 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Test: notify new user about wikitext mention on Flow talk page 'flow-mention' notification
Change 348764 had a related patch set uploaded (by Zfilipin; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] Echo should notify new user about Flow mention on Flow talk page
Change 348764 abandoned by Zfilipin:
Echo should notify new user about Flow mention on Flow talk page
Reason:
Not working on Ruby tests any more, but on Node.js tests (T177412).
Change 348769 abandoned by Zfilipin:
Test: notify an author of a Flow topic when another user posts a reply
Reason:
Not working on Ruby tests any more, but on Node.js tests (T177412).
Change 348774 abandoned by Zfilipin:
Test: notify a user who watches a Flow board when another user creates a new topic there
Reason:
Not working on Ruby tests any more, but on Node.js tests (T177412).
Change 348775 abandoned by Zfilipin:
Test: notify user about new edits on user talk page
Reason:
Not working on Ruby tests any more, but on Node.js tests (T177412).
@Etonkovidova and I have talked about this and decided to resolve this one. I am working on T139740: Port Selenium tests from Ruby to Node.js so having API tests in Ruby does not make much sense. API tests for Echo will be implemented in Node.js, see T177412: Mocha tests for Echo notifications.
Change 348768 abandoned by Zfilipin:
Test:should notify a new user about edits to his post done by Admin
Reason:
Not working on Ruby tests any more, but on Node.js tests (T177412).