Page MenuHomePhabricator
Create Task
Maniphest T136780

[betalabs] 'Uncaught TypeError: Cannot read property 'model' of undefined' for non-persistent Comments in Flow posts
Closed, ResolvedPublic
Actions

Description

  1. In a new post Reply insert only a Comment(s) (no text)
  2. Save the post.
  3. Click to edit the post - nothing will be displayed in VE or wikitext editor.

Non-Flow pages display saved Comments even if there is no other content on a page.

The backtrace will be displayed in the Console:

Screen Shot 2016-06-01 at 4.45.12 PM.png (527×1 px, 235 KB)

Uncaught TypeError: Cannot read property 'model' of undefined
at VeCeDocument.ve.ce.Document.getNodeAndOffset  URL1:437:264
at VeCeSurface.ve.ce.Surface.annotationsAtModelSelection  URL1:564:94
at VeCeSurface.ve.ce.Surface.onDocumentMouseDown  URL1:504:404
at HTMLDivElement.dispatch  URL2:173:742
at HTMLDivElement.elemData.handle  URL2:170:388

URL1: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=1nvm6
URL2: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.CodeMirror%2Ccharinsert%2CdismissableSiteNotice%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.CodeMirror.data%7Cext.centralNotice.geoIP%7Cext.centralauth.centralautologin%7Cext.translate.edit.documentation%7Cext.translate.pagetranslation.uls%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinit%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Ci18n%2CtextSelection%2Cui%2Culs%7Cjquery.uls.data%2Cgrid%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.ui.button%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-styling%2Cindicators%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=1coqf

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (8b37f95f1)mediawiki/extensions/VisualEditormaster+1 -1
Catch errors from getNodeAndOffset in ve.ce.Surface#focusVisualEditor/VisualEditormaster+10 -3
Update VE core submodule to master (53af216aa)mediawiki/extensions/VisualEditormaster+23 -15
Catch errors from getNodeAndOffset in annotationsAtModelSelectionVisualEditor/VisualEditormaster+14 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Jun 1 2016, 11:47 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 1 2016, 11:47 PM
Catrope added a project: StructuredDiscussions.Jun 3 2016, 8:41 AM
• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collab-Team-2016-Apr-Jun-Q4.Jun 6 2016, 9:41 PM
• jmatazzoni moved this task from Untriaged to Hot on the Collaboration-Team-Triage board.
Aklapper edited projects, added Growth-Team; removed Collaboration-Team-Triage.Oct 12 2019, 4:13 AM
Jdlrobson added projects: VisualEditor, Wikimedia-production-error.Sep 9 2020, 10:56 PM
Jdlrobson subscribed.

Not just flow.
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.09/clienterror/?id=AXR0uM6JNoG2jwpwzcr8

JTannerWMF added a project: Editing-team (Kanban Board).Sep 10 2020, 4:26 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF subscribed.

we will take a look

JTannerWMF moved this task from Inbox to Upcoming on the Editing-team (Kanban Board) board.Sep 10 2020, 4:26 PM
ppelberg edited projects, added Editing-team (Tracking); removed Editing-team (Kanban Board).Sep 10 2020, 4:44 PM
ppelberg moved this task from Backlog to FY2020-21 on the Editing-team (Tracking) board.
Esanders updated the task description. (Show Details)Sep 11 2020, 11:43 AM
Jdlrobson moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 16 2020, 6:49 PM
Umherirrender added a project: JavaScript.Sep 16 2020, 7:55 PM
gerritbot added a comment.Sep 17 2020, 12:03 PM

Change 628076 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

gerritbot added a project: Patch-For-Review.Sep 17 2020, 12:03 PM
gerritbot added a comment.Sep 17 2020, 12:14 PM

Change 628076 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

Esanders added subscribers: dchan, Esanders.Sep 17 2020, 12:15 PM

This one is a bit concerning because it isn't from a throw, so we should still see if we can reproduce this somehow. CC @dchan

gerritbot added a comment.Sep 17 2020, 12:21 PM

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

gerritbot added a comment.Sep 17 2020, 6:20 PM

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 7:12 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Sep 17 2020, 7:22 PM
matmarex moved this task from Upcoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
matmarex subscribed.

Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.

matmarex moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 2 2020, 2:40 AM

Deployed with wmf.10 on 24 September. There is one entry on 2020-09-27 with this error message: https://logstash.wikimedia.org/goto/ed3a3516c9e04d6f354447c43a5b1142

image.png (405×2 px, 40 KB)

Different backtrace though:

at VeCeDocument.ve.ce.Document.getNodeAndOffset  ...:370:410
at VeCeSurface.ve.ce.Surface.focus  ...:431:821
at Object.ve.ce.LinearDeleteKeyDownHandler.static.execute  ...:524:957
at VeCeKeyDownHandlerFactory.ve.ce.KeyDownHandlerFactory.executeHandlersForKey  ...:508:377
at VeCeSurface.ve.ce.Surface.onDocumentKeyDown  ...:445:591
at VeEventSequencer.ve.EventSequencer.callListener  ...:24:768
at VeEventSequencer.ve.EventSequencer.onEvent  ...:22:136
at HTMLDivElement.<anonymous>  ...:19:930
at HTMLDivElement.dispatch  ...:69:742
at HTMLDivElement.elemData.handle  ...:66:388
ppelberg added a parent task: T264487: Confirm client-side errors are no longer occurring .Oct 3 2020, 1:42 AM
JTannerWMF removed projects: Editing-team (Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor, Growth-Team, StructuredDiscussions.Oct 14 2020, 3:09 PM
JTannerWMF added projects: VisualEditor, Wikimedia-production-error, JavaScript, Editing-team (Tracking).Oct 14 2020, 3:15 PM
matmarex edited projects, added StructuredDiscussions, Growth-Team, Editing-team (Kanban Board); removed Editing-team (Tracking).Oct 14 2020, 3:33 PM
gerritbot added a comment.Nov 9 2020, 11:19 AM

Change 640091 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

gerritbot added a project: Patch-For-Review.Nov 9 2020, 11:19 AM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Nov 9 2020, 11:20 AM
gerritbot added a comment.Nov 11 2020, 11:00 PM

Change 640091 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2020, 11:11 PM
Esanders assigned this task to matmarex.Nov 14 2020, 2:36 PM
Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders added a project: Skipped QA.
gerritbot added a comment.Nov 16 2020, 10:27 PM

Change 641268 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

gerritbot added a project: Patch-For-Review.Nov 16 2020, 10:27 PM
gerritbot added a comment.Nov 16 2020, 10:55 PM

Change 641268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2020, 11:11 PM
ppelberg closed this task as Resolved.Nov 17 2020, 2:49 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 17 2020, 2:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits