Page MenuHomePhabricator

[betalabs] 'Uncaught TypeError: Cannot read property 'model' of undefined' for non-persistent Comments in Flow posts
Closed, ResolvedPublic

Description

  1. In a new post Reply insert only a Comment(s) (no text)
  2. Save the post.
  3. Click to edit the post - nothing will be displayed in VE or wikitext editor.

Non-Flow pages display saved Comments even if there is no other content on a page.

The backtrace will be displayed in the Console:

Screen Shot 2016-06-01 at 4.45.12 PM.png (527×1 px, 235 KB)

Uncaught TypeError: Cannot read property 'model' of undefined
at VeCeDocument.ve.ce.Document.getNodeAndOffset  URL1:437:264
at VeCeSurface.ve.ce.Surface.annotationsAtModelSelection  URL1:564:94
at VeCeSurface.ve.ce.Surface.onDocumentMouseDown  URL1:504:404
at HTMLDivElement.dispatch  URL2:173:742
at HTMLDivElement.elemData.handle  URL2:170:388

URL1: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=1nvm6
URL2: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.CodeMirror%2Ccharinsert%2CdismissableSiteNotice%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.CodeMirror.data%7Cext.centralNotice.geoIP%7Cext.centralauth.centralautologin%7Cext.translate.edit.documentation%7Cext.translate.pagetranslation.uls%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinit%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Ci18n%2CtextSelection%2Cui%2Culs%7Cjquery.uls.data%2Cgrid%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.ui.button%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-styling%2Cindicators%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=1coqf

Event Timeline

Change 628076 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

Change 628076 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

This one is a bit concerning because it isn't from a throw, so we should still see if we can reproduce this somehow. CC @dchan

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

matmarex subscribed.

Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.

Deployed with wmf.10 on 24 September. There is one entry on 2020-09-27 with this error message: https://logstash.wikimedia.org/goto/ed3a3516c9e04d6f354447c43a5b1142

image.png (405×2 px, 40 KB)

Different backtrace though:

at VeCeDocument.ve.ce.Document.getNodeAndOffset  ...:370:410
at VeCeSurface.ve.ce.Surface.focus  ...:431:821
at Object.ve.ce.LinearDeleteKeyDownHandler.static.execute  ...:524:957
at VeCeKeyDownHandlerFactory.ve.ce.KeyDownHandlerFactory.executeHandlersForKey  ...:508:377
at VeCeSurface.ve.ce.Surface.onDocumentKeyDown  ...:445:591
at VeEventSequencer.ve.EventSequencer.callListener  ...:24:768
at VeEventSequencer.ve.EventSequencer.onEvent  ...:22:136
at HTMLDivElement.<anonymous>  ...:19:930
at HTMLDivElement.dispatch  ...:69:742
at HTMLDivElement.elemData.handle  ...:66:388

Change 640091 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

Change 640091 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

Change 641268 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

Change 641268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268