Page MenuHomePhabricator
Create Task
Maniphest T119926

Regression: wgRelatedArticlesShowReadMore defaults to false on wikivoyage
Closed, ResolvedPublic
Actions

Description

On https://en.wikivoyage.org/wiki/New_York_City you'll see the historical "Related pages" menu item in the left menu (note this is DESKTOP).
It's not showing up in http://en.wikivoyage.beta.wmflabs.org/wiki/Related_test
as it's being controlled by wgRelatedArticlesShowReadMore which is defaulting to false

The historical menu item should be determined by a separate configuration variable and not be controlled by wgRelatedArticlesShowReadMore

  • It should be possible to enable read more (footer via beta features) but disable the left menu behaviour (e.g. for English Wikipedia)
  • If read more footer and left menu are both enabled on Vector I see both (for time being until features have been consolidated - needed by Wikivoyage)
  • If read more (footer) is enabled and related articles (left menu) is enabled but I do not have the beta feature enabled then I see the links in the left menu.
  • If read more (footer) is enabled and related articles (left menu) is disabled but I do not have the beta feature enabled then I see no links in the left menu and no links in the footer.
  • If read more (footer) is disabled and related articles (left menu) is disabled I see nothing.

Introduced by T117444

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Configure footer and sidebar placementsmediawiki/extensions/RelatedArticlesdev+7 -7
Correctly show related articles on desktopmediawiki/extensions/RelatedArticlesdev+43 -40
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 1 2015, 1:24 AM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Reading Web Sprint 61 - Cold Hard Cache, RelatedArticles.
Jdlrobson moved this task to Goals on the Reading Web Sprint 61 - Cold Hard Cache board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2015, 1:24 AM
Jdlrobson mentioned this in T117444: RelatedArticles feature should be available in beta features.Dec 1 2015, 1:25 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson moved this task from Goals to To Do on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 1 2015, 1:27 AM
• bmansurov subscribed.Dec 1 2015, 3:46 AM

The historical menu item should be determined by a separate configuration variable and not be controlled by wgRelatedArticlesShowReadMore

Since both ReadMore and historical menu show the same information, wouldn't it make more sense to show either?

gerritbot subscribed.Dec 1 2015, 3:48 AM

Change 256166 had a related patch set uploaded (by Bmansurov):
Correctly show related articles on desktop

https://gerrit.wikimedia.org/r/256166

gerritbot added a project: Patch-For-Review.Dec 1 2015, 3:48 AM
• bmansurov moved this task from To Do to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 1 2015, 3:48 AM
• bmansurov claimed this task.Dec 1 2015, 10:02 AM
phuedx subscribed.Dec 1 2015, 10:37 AM

The historical menu item should be determined by a separate configuration variable and not be controlled by wgRelatedArticlesShowReadMore

See 253919 and 253920.

Aklapper added a project: Regression.Dec 1 2015, 11:23 AM
phuedx added a subscriber: • jhobs.Dec 1 2015, 1:55 PM

Seeking another reviewer /cc @Jdlrobson @jhobs

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 1 2015, 6:59 PM
gerritbot added a comment.Dec 1 2015, 8:55 PM

Change 253920 had a related patch set uploaded (by Jdlrobson):
Configure footer and sidebar placements

https://gerrit.wikimedia.org/r/253920

Jdlrobson updated the task description. (Show Details)Dec 2 2015, 2:06 AM
gerritbot added a comment.Dec 2 2015, 2:08 AM

Change 256166 merged by jenkins-bot:
Correctly show related articles on desktop

https://gerrit.wikimedia.org/r/256166

Jdlrobson updated the task description. (Show Details)Dec 2 2015, 2:09 AM

Merged Baha's patch but Sam's patch (https://gerrit.wikimedia.org/r/253920) is needed to call this complete.

Jdlrobson reassigned this task from • bmansurov to phuedx.Dec 2 2015, 2:09 AM
phuedx updated the task description. (Show Details)Dec 2 2015, 12:18 PM

It should be possible to enable read more (footer via beta features) but disable the left menu behaviour (e.g. for English Wikipedia)

This is possible as of T119926#1843662.

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 2 2015, 4:45 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 2 2015, 10:41 PM
gerritbot added a comment.Dec 2 2015, 10:42 PM

Change 253920 merged by jenkins-bot:
Configure footer and sidebar placements

https://gerrit.wikimedia.org/r/253920

Jdlrobson closed this task as Resolved.Dec 2 2015, 11:01 PM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 8 2015, 12:25 AM

Confirmed it shows in sidebar but not footer for Wikivoyage http://en.wikivoyage.beta.wmflabs.org/w/index.php?title=Related_test&mobileaction=toggle_view_desktop

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits