Page MenuHomePhabricator
Create Task
Maniphest T111609

Safari 8: Mediaviewer failing in mobile when file names include special characters
Closed, ResolvedPublic
Actions

Description

In Safari 8.0.5 navigate to this sandbox, when viewed in mobile mode on desktop or mobile, MediaViewer only works for the first two images. The last three all of which have non-ASCII characters in their names fail. The error from the browser console is:

[Error] URIError: URI error
        decodeURIComponent (undefined, line 111)
        (anonymous function)
        fire (load.php, line 45)
        add (load.php, line 45)
        loadImageOverlay
        _matchRoute
        (anonymous function)
        each (load.php, line 5)
        _checkRoute
        proxy (load.php, line 6)
        emit
        (anonymous function)
        dispatch (load.php, line 65)
        handle (load.php, line 60)

Reported here:

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Problem_with_media_viewer_in_.22mobile_view.22_on_mobile_devices

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix media viewer for files with special charactersmediawiki/extensions/MobileFrontendmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

JohnBlackburne created this task.Sep 5 2015, 7:44 PM
JohnBlackburne raised the priority of this task from to Needs Triage.
JohnBlackburne updated the task description. (Show Details)
JohnBlackburne added a project: MediaViewer.
JohnBlackburne subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 5 2015, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr edited projects, added Web-Team-Backlog-Archived; removed Multimedia, MediaViewer.Sep 6 2015, 5:38 AM
Tgr set Security to None.
Tgr subscribed.Sep 6 2015, 5:40 AM

Works fine for me; probably browser-dependent.

Amire80 renamed this task from Mediiaviewer failing in mobile when file names include special charaters to Mediaviewer failing in mobile when file names include special charaters.Sep 6 2015, 7:26 AM
JohnBlackburne added a comment.Sep 6 2015, 1:18 PM

More detail: the original report said it failed on iPad, so mobile Safari, version unspecified. I My own tests were with Safari 8.0.8 on Mac OS 10.10.5. Safari on desktop is not a major browser on desktop but is on mobile.

JohnBlackburne renamed this task from Mediaviewer failing in mobile when file names include special charaters to Mediaviewer failing in mobile when file names include special characters.Sep 7 2015, 1:08 AM
Jdlrobson added projects: MobileFrontend, MediaViewer.Sep 8 2015, 11:45 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 8 2015, 11:45 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 10 2015, 1:14 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 10 2015, 1:14 AM
Jdlrobson triaged this task as Medium priority.Sep 14 2015, 8:49 PM
Jdlrobson renamed this task from Mediaviewer failing in mobile when file names include special characters to Safari 8: Mediaviewer failing in mobile when file names include special characters.Sep 14 2015, 8:51 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.

(Confirmed in Safari 8)

Jdlrobson edited projects, added Reading-Web-Sprint-56-Four Lions; removed Web-Team-Backlog-Archived.Sep 14 2015, 8:52 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-56-Four Lions board.
• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.Sep 16 2015, 5:12 PM
Jdforrester-WMF subscribed.Sep 21 2015, 3:39 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:49 PM
phuedx claimed this task.Sep 24 2015, 12:41 PM
phuedx moved this task from To Do to Doing on the Reading-Web-Sprint-56-Four Lions board.
gerritbot subscribed.Sep 24 2015, 1:04 PM

Change 240688 had a related patch set uploaded (by Phuedx):
Fix media viewer for files with special characters

https://gerrit.wikimedia.org/r/240688

gerritbot added a project: Patch-For-Review.Sep 24 2015, 1:04 PM
phuedx moved this task from Doing to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 24 2015, 1:04 PM
• jhobs subscribed.EditedSep 24 2015, 6:40 PM

@phuedx see https://gerrit.wikimedia.org/r/240688 for slight change

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-56-Four Lions board.Sep 24 2015, 8:17 PM

@jhobs the same fix is needed for desktop in MediaViewer - would you be able to do that?

• jhobs added a comment.Sep 24 2015, 8:22 PM

@Jdlrobson I'm unable to reproduce the error on desktop. If you are able to reproduce it, could you open a new task for it?

Jdlrobson added a comment.Sep 24 2015, 8:23 PM

@jhobs visit https://en.wikipedia.org/wiki/User:Mare44/sandbox in Safari. Click on image and then click right/left arrows.

• jhobs added a comment.EditedSep 24 2015, 8:24 PM

@Jdlrobson works fine for me =/ Safari version 8.0.6

Jdlrobson added a comment.Sep 24 2015, 10:21 PM

Me too. I guess the desktop version got fixed in the deployment today as it wasn't working this morning :)

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 24 2015, 10:21 PM
gerritbot added a comment.Sep 25 2015, 5:06 AM

Change 240688 merged by jenkins-bot:
Fix media viewer for files with special characters

https://gerrit.wikimedia.org/r/240688

Diffusion mentioned this in rMEXT39dc5326c962: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 25 2015, 5:07 AM
• jhobs mentioned this in rEMFRda0ec3e12c82: Fix media viewer for files with special characters.Sep 25 2015, 5:07 AM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 25 2015, 6:50 AM
Jdlrobson closed this task as Resolved.Sep 25 2015, 4:53 PM

Confirmed fixed on http://en.m.wikipedia.beta.wmflabs.org/wiki/Gallery_media_view_test in Safari

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.Sep 25 2015, 4:53 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:18 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
phuedx mentioned this in T118553: Escape thumbnail URL before rendering it in CSS context.Nov 19 2015, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits