fix(login): handle LDAP IDP mapping and nullable SSR settings#12217
Open
axellpadilla wants to merge 5 commits into
Open
fix(login): handle LDAP IDP mapping and nullable SSR settings#12217axellpadilla wants to merge 5 commits into
axellpadilla wants to merge 5 commits into
Conversation
fix(cache): handle undefined results in PromiseCache fix(security): ensure proper handling of fetch results in getIframeOrigins test: add unit tests for Zitadel settings helpers
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@axellpadilla is attempting to deploy a commit to the zitadel Team on Vercel. A member of the Team first needs to authorize it. |
hifabienne
added
the
os-contribution
|
View your CI Pipeline Execution ↗ for commit ed5048b
☁️ Nx Cloud last updated this comment at |
axellpadilla
changed the title
axellpadilla
force-pushed
the
fix/login-ldap-idp-mapping-12210
branch
2 times, most recently
from
99a20e1 to
ec34279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
idpTypeToIdentityProviderType()did not mapIDP_TYPE_LDAP.undefined, becauselru-cachetreats a rawundefinedresult fromfetchMethodas a fetch failure.How the Problems Are Solved
IDP_TYPE_LDAPtoIdentityProviderType.LDAP.undefinedvalues insidePromiseCachebefore storing them inlru-cache, then unwrap them on read.getIframeOrigins()contract by normalizing cachedundefinedvalues tonull.Tests
undefinedvalues inPromiseCache.Security Notes
nullwhen settings are missing, disabled, empty, or cannot be fetched.Closes #12210, Closes #12221