Switch to using system fonts#230
Conversation
samwilson
changed the title
MusikAnimal
left a comment
MusikAnimal
left a comment
There was a problem hiding this comment.
Code looks OK to me, though I admit I don't really understand how the system works. I was going to test this on https://wsexport-test.wmflabs.org/, but first things first -- I can't repro the original issue. On my end, all characters appear correctly when exporting this book (linked to the description for T254918) on production. I do not see any boxes. Are there other examples I could try?
I am still going to 👍 because I trust you :)
You might have fonts installed that support Kannada. I think the issue is most likely to come up when a book is exported on a system with the right fonts (and so everything looks fine) is transferred to a device (e.g. an ereader) that doesn't have the right fonts. With this fix, the user will be given the option to embed the correct font, but they'll still have to actually do that to avoid the issue.
hehe thanks. I'll make sure not to put it into production without good testing on the test site! |
Rather than including our own fonts, instead include fonts from the host system. Their details will be cached in a new qqq directory alongside the existing language-specific cache files. Bug: T261479
|
New branch for this: #248 |
2 participants
Rather than including our own fonts, instead include fonts from
the host system.
https://phabricator.wikimedia.org/T261479