Skip to content

Set targets to fix "Module not loadable on target mobile" warnings#1

Closed
jdlrobson wants to merge 1 commit into
mainfrom
T324723
Closed

Set targets to fix "Module not loadable on target mobile" warnings#1
jdlrobson wants to merge 1 commit into
mainfrom
T324723

Conversation

@jdlrobson
Copy link
Copy Markdown
Member

Hey @matthiasmullie can you take a look at this? Not sure what this module is for, but it's showing up in error logs as part of https://phabricator.wikimedia.org/T324723.

Thanks in advance!

I'm not sure what this empty module is doing but if it's loaded on
desktop, it should also be loaded on mobile.

Bug: T324723
@wikimedia-helper-bot-for-github
Copy link
Copy Markdown

👋 Hi @jdlrobson,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed.

If you are interested in sticking around within the Wikimedia community, please take a look at https://www.mediawiki.org/wiki/New_Developers
Thanks in advance!

@jdlrobson
Copy link
Copy Markdown
Member Author

@matthiasmullie I'm also having issues pushing this to gerrit so I am a little confused with where the source of truth is for this code!

@jdlrobson
Copy link
Copy Markdown
Member Author

Looks like I just had to run git review master (it was defaulting to main)

@jdlrobson
Copy link
Copy Markdown
Member Author

@matthiasmullie
Copy link
Copy Markdown
Member

FYI: this repo was first created with "main" as its main branch; that got changed back to "master" over translatewiki incompatibilities. Looks like there's still some leftover stuff though.

Anyway - thanks for the patch, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants