Skip to content

Upgrade MediaWiki to 1.31#49

Merged
davidbarratt merged 1 commit into
wikimedia:masterfrom
magol:1.31
Jun 14, 2018
Merged

Upgrade MediaWiki to 1.31#49
davidbarratt merged 1 commit into
wikimedia:masterfrom
magol:1.31

Conversation

@magol
Copy link
Copy Markdown

@magol magol commented Jun 14, 2018

No description provided.

legoktm
legoktm requested changes Jun 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SyntaxHighlight in 1.31 needs Python 3 now (python3), not Python 2 (python).

@magol
Copy link
Copy Markdown
Author

magol commented Jun 14, 2018

@legoktm ups, I have fixed that now

davidbarratt
davidbarratt requested changes Jun 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@davidbarratt davidbarratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this as an opperunity to update pecl install apcu-5.1.8 to pecl install apcu (in stable)? I'm not sure why I had it pinned to begin with, but it seems to work just fine now.

@magol
Copy link
Copy Markdown
Author

magol commented Jun 14, 2018

@davidbarratt If no-one disagree, I agree that we should updating apcu to the latest version.

@davidbarratt davidbarratt merged commit 1aeea64 into wikimedia:master Jun 14, 2018
@davidbarratt
Copy link
Copy Markdown
Member

davidbarratt commented Jun 14, 2018

Docker Hub PR
docker-library/official-images#4463

@magol magol deleted the 1.31 branch June 14, 2018 19:39
@tianon
Copy link
Copy Markdown
Collaborator

tianon commented Jun 15, 2018

Just for future reference, see https://github.com/docker-library/docs/tree/master/php#pecl-extensions for why pinning PECL to a specific version is recommended:

It is strongly recommended that users use an explicit version number in their pecl install invocations to ensure proper PHP version compatibility (PECL does not check the PHP version compatiblity when choosing a version of the extension to install, but does when trying to install it).

For example, memcached-2.2.0 has no PHP version constraints (https://pecl.php.net/package/memcached/2.2.0), but memcached-3.0.4 requires PHP 7.0.0 or newer (https://pecl.php.net/package/memcached/3.0.4). When doing pecl install memcached (no specific version) on PHP 5.6, PECL will try to install the latest release and fail.

Beyond the compatibility issue, it's also a good practice to ensure you know when your dependencies receive updates and can control those updates directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legoktm legoktm legoktm requested changes

@davidbarratt davidbarratt davidbarratt approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magol @davidbarratt @tianon @legoktm