Fix: validate the login status for logged-in-required screens#6643
Open
cooltey wants to merge 8 commits into
Open
Fix: validate the login status for logged-in-required screens#6643cooltey wants to merge 8 commits into
cooltey wants to merge 8 commits into
Conversation
cooltey
changed the title
dbrant
requested changes
May 28, 2026
Member
dbrant
left a comment
dbrant
left a comment
There was a problem hiding this comment.
This is the correct path, but will need some more behavioral updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This prevents the user from seeing the errors in the Activity tab, Year-in-Review, or Watchlist, as the cookie may have expired, but the app still believes the user is logged in.
This PR creates an
MwCoroutineExceptionHandlerinThrowableUtil, and replaces the generalCoroutineExceptionHandlerto catch theassertuserfailedornotloggedinerror code. If it catches one of the error codes, the app will log out the user and prompt the login dialog to do relogin.Phabricator:
https://phabricator.wikimedia.org/T427439