Skip to content

Improve display of Blocked messages, and make snackbar selectable.#6636

Merged
cooltey merged 2 commits into
mainfrom
blockErrorTemplate
May 26, 2026
Merged

Improve display of Blocked messages, and make snackbar selectable.#6636
cooltey merged 2 commits into
mainfrom
blockErrorTemplate

Conversation

@dbrant
Copy link
Copy Markdown
Member

@dbrant dbrant commented May 26, 2026

  • When a snackbar has a duration of INDEFINITE, let's make the text highlightable and copiable.
  • For Blocked messages, it's actually not correct for us to wrap the username parameter in an anchor element, since this can mess with the template logic in certain language wikis. It's totally fine to leave the username un-wrapped, and let the template do its own thing.

https://phabricator.wikimedia.org/T413516

@dbrant dbrant requested review from Williamrai and cooltey as code owners May 26, 2026 20:17
@dbrant dbrant added Minor Minor stuff High Priority Priority code review needed labels May 26, 2026
@cooltey cooltey merged commit b7ac078 into main May 26, 2026
1 check passed
@cooltey cooltey deleted the blockErrorTemplate branch May 26, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority Priority code review needed Minor Minor stuff

Development

Successfully merging this pull request may close these issues.

3 participants