[Feature branch] Explore Feed Redesign#6446
Merged
Merged
Conversation
* - adds navigation arch * - simplify navigation
* - adds ExploreFeedUpdatePromptActivity - adds strings for ExploreFeedUpdatePromptActivity - adds preference for controlling ExploreFeedUpdatePromptActivity access - adds icon resources * - open explore feed update prompt from feed fragment - code fixes * - code fixes
* Explore Feed: Onboarding: Intro Screens and Context Setting * Integrate with the initialOnboardingActivity * Almost * Optimize * Code review comments * Update asset, function and handle navigation bar correctly
…ps-android-wikipedia into explore-feed-upgrade-design
* NewExploreFeed: the Feed building screen * Update asset and ready for design signoff
* NewExploreFeed: Languages pick screen * Callbacks * Finishing up * Language pick * Add language selection to initialOnboarding screen * Fix * Update content description
* Allow edge-to-edge for MainActivity, enabling full-bleed compositions. * Remove redundant name. * Initial exploration of HomeFragment. * Yes. * Remember snap fling state. * Yep. * Bunch of hacks for applying non-default theme colors to NavBar. * Imports. * Explicitly set LightSystemUiVisibility. * Framework for Home fragment in Compose. * Properly account for status bar inset. * Refactor a bit. * Further solidify. * Break out ViewModel. * Review comments. * Remove annotation. * Apply different themes when switching tabs, and fill out some more. * OK... * Wire up. * Alright... * Alright!
* NewExploreFeed: rename "Explore" to "Home" * update for strings that may not be used later * add qq strings * Code review comments * Fix merge issue * Fix reference
* Community Picks: Top Read Module * Better paddings * wire to home * Clickable area: * click behavior * Adding trending up/down icons * Update token * Finalized * Pull to refresh * show localized name in the description * Remove language text
…ps-android-wikipedia into explore-feed-upgrade-design
…design # Conflicts: # app/src/main/res/values-qq/strings.xml
#6598) * - adds AppAnnouncements for handling announcement activities - blocks announcements while onboarding-related activities are on screen - requires initial onboarding to be complete before any announcement fires - requires ExploreFeedUpdatePrompt to be completed before announcements fire for existing users * - adds announcement logic back to base activity * - code fixes
* - adds code to handle the empty state when the user has not selected any interests or has no reading history - removes home preference from customization flow when adding new interset * - adds new design for "For you" empty state - adds ForYouEmptyState - adds related string for empty state * - updates string * - code fixes * - strings update * - string fixes * - string fixes * - adds "interest only" instead of "intro page only" for customizing interests - hides skip and page indicator when there is only one page in interest selection onboarding flow - code/ui fixes * - split selectTab behavior into two separate functions (selectTab and reloadCurrentTab) * - handles no data view for Community Feed - code fixes * - proper naming for empty view --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
* Home feed: instrumentation for Empty states. * Set subtype only if card is not empty.
* - implements Feed Configuration screen - empties Prefs.homeForYouModulesToday when user selects new interest from the Settings flow in order to fetch new content in the HomeFragment - code/ui fixes - adds new strings * - adds flow queries to show dynamic subtitles in Feed Configuration based on user data - * - code fixes * Wrap the content with Box * - trigger for you reload via activity result instead of onResume * - allow user to navigate back to setting screen * - use proper file name --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
* - Shows the correct topic string based on the selected language - displays the correct primary language in the Home tab bar. * - code fixes * - code fixes * - code fixes
… when interests are changed in Settings (#6618)
…o explore-feed-upgrade-design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T407990