Wikigames: set initial currentState from Prefs#5354
Closed
cooltey wants to merge 16 commits into
Closed
Conversation
Williamrai
reviewed
Feb 27, 2025
Williamrai
left a comment
Williamrai
left a comment
Collaborator
There was a problem hiding this comment.
The changes looks good. I think with this change we can also remove this additional logic, since we are persisting the state.
else if (_gameState.value == null || ::currentState.isInitialized.not()) {
"unknown"
}
Collaborator
This has been resolved. |
cooltey
changed the title
dbrant
requested changes
Mar 4, 2025
| val langToState = totalState.langToState.toMutableMap() | ||
| langToState[wikiSite.languageCode] = currentState | ||
| Prefs.otdGameState = JsonUtil.encodeToString(TotalGameState(langToState)).orEmpty() | ||
| savedStateHandle[KEY_CURRENT_STATE] = JsonUtil.encodeToString(currentState) |
Member
There was a problem hiding this comment.
The entire game state gets saved to Prefs (on the previous line). Do we really need to duplicate it into savedStateHandle?
cooltey
changed the title
Collaborator
Author
|
The current approach seems perfectly fine, so close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR sets the current game state from the Prefs when the ViewModel is created.
Also moved the
impressionevent to the end ofonGameEnded()in the case ofgameStatebeingnull.https://phabricator.wikimedia.org/T387418