Skip to content

feat: add examples for single and multiple entries prompt (#162)#167

Merged
DanielaValero merged 1 commit into
webpack:masterfrom
avivr:feature/162-add-example-entry
Jul 3, 2017
Merged

feat: add examples for single and multiple entries prompt (#162)#167
DanielaValero merged 1 commit into
webpack:masterfrom
avivr:feature/162-add-example-entry

Conversation

@avivr

@avivr avivr commented Jun 25, 2017

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Add example when prompting for single / multiple entries.

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

Address issue #162

Does this PR introduce a breaking change?

No

Other information
Sample screenshot -
screen shot 2017-06-25 at 23 33 16

@avivr

avivr commented Jun 25, 2017

Copy link
Copy Markdown
Contributor Author

btw, I followed the instrcutions on the CONTRIBUTING.md 'Setup' section and installed the commit validator but then I couldn't commit at all.
Got the following error:

ERR! Error Commit message invalid
ERR! Error[tags]: You used 0 tag(s) in your commit message. Use only 1.

The commit message was "feat: add examples for single and multiple entries prompt (#162)", which seems to me align with the commit format. What am I missing?

I couldn't find what was wrong with the commit message so I had to execute fit-commit-js uninstall to remove the git-hook and be able to commit.

evenstensberg
evenstensberg approved these changes Jun 26, 2017
View reviewed changes

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM , @okonet 2nd review and answer comment

@DanielaValero

DanielaValero commented Jul 3, 2017

Copy link
Copy Markdown
Contributor

Hi @avivr The commit validator has a bug, I'll migrate it to comitizen soon and update the setup instructions.

@evenstensberg

evenstensberg commented Jul 3, 2017

Copy link
Copy Markdown
Member

Guess we can merge this though? @DanielaValero

@DanielaValero DanielaValero merged commit 37c40f0 into webpack:master Jul 3, 2017
@avivr avivr deleted the feature/162-add-example-entry branch July 3, 2017 19:21
@enterstudio enterstudio mentioned this pull request Nov 5, 2022
Open
@dhruvdutt dhruvdutt mentioned this pull request Nov 5, 2022
Open
@enterstudio enterstudio mentioned this pull request Dec 26, 2022
Open
@dhruvdutt dhruvdutt mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evenstensberg evenstensberg evenstensberg approved these changes
@okonet okonet Awaiting requested review from okonet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avivr @DanielaValero @evenstensberg