chore(logger): remove logger package, inline webpack logger#1358
Conversation
anshumanv
dismissed stale reviews from wizardofhogwarts, jamesgeorge007, shivaylamba, himanshu010, and snitin315
via
298842c
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @webpack/cli-team need more reviews
|
@evilebottnawi rebased which removed your review, PTAL again. ✨ |
|
/cc @webpack/cli-team need more reviews |
|
PTAL @evilebottnawi @rishabh3112, let's get this in. 🌟 |
|
Uhoh, taking look at tests. |
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
| @@ -1,3 +1,3 @@ | |||
| const { logger } = require('@webpack-cli/logger'); | |||
| const { getLogger } = require('webpack/lib/logging/runtime'); | |||
There was a problem hiding this comment.
webpack/lib/logging/runtime should not be used here. Use compiler.getInfrastructureLogger("webpack-cli") instead.
There was a problem hiding this comment.
@sokra we use logging before run webpack and after, and when we do other actions which don't need webpack (like init/info/migrate/generate), so we can't use infrastructure logger
11 participants
What kind of change does this PR introduce?
Remove logger package.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No
Other information
NA