Rename syntax implicits so they don't clash with other libraries#126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as typelevel/cats-mtl#661, but in this library. I'm not sure how the maintainers want the formatting to look; the scalafmt output was ugly so I expanded the
// format: offblocks for some of the new code.The rest of the description is the same as typelevel/cats-mtl#661:
I was trying to use the new custom error types technique with cats-mtl in a Skunk-using project and ran into an unfortunate name collision. AFAICT if you
you end up importing two
implicit def toTupleOpsmethods, one fromTwiddleCompat(via Twiddles, via Skunk) and one fromTellSyntaxvia cats-mtl. On Scala 2, they cancel each other out and you end up with errors likeOf course, I could do
import cats.mtl.syntax.raise._or evenimport cats.mtl.syntax.all.{toTupleOps => _, _}, but that's a little unfortunate when teaching the new technique generally. (And users who want to useTellwith Twiddles have to figure out that they need to do something likeimport cats.mtl.syntax.all.{toTupleOps => catsMtlSyntaxToTupleOps, _}, which is not easily discoverable at all.)This PR binary-compatibility renames the implicits using the naming pattern established in Cats, which should make it unlikely that these implicit methods will clash with the implicits from other libraries.