Improve error reporting for rep0, repAs0#396
Merged
Merged
Conversation
Contributor
Author
|
cc @carueda |
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 96.65% 96.63% -0.02%
==========================================
Files 9 9
Lines 1284 1278 -6
Branches 124 115 -9
==========================================
- Hits 1241 1235 -6
Misses 43 43
Continue to review full report at Codecov.
|
johnynek
commented
Mar 28, 2022
| } | ||
| } | ||
|
|
||
| case class Rep0[A, B](p1: Parser[A], maxMinusOne: Int, acc: Accumulator0[A, B]) |
Contributor
Author
There was a problem hiding this comment.
in the presence of the a.? ~ b optimization, if we want consistency, it is better to just remove Rep0 entirely and represent it in the same way so we don't have any chance of breaking the symmetry there.
regadas
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
give rep0/repAs0 the same treatment as #389