Skip to content

Use scalafmt scala213 runner dialect#359

Merged
johnynek merged 2 commits into
typelevel:mainfrom
regadas:scalafmt_tweak
Jan 27, 2022
Merged

Use scalafmt scala213 runner dialect#359
johnynek merged 2 commits into
typelevel:mainfrom
regadas:scalafmt_tweak

Conversation

@regadas

@regadas regadas commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

It's ok to use it and for metals users, it will avoid the nagging.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #359 (b2dcd04) into main (112d92a) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

❗ Current head b2dcd04 differs from pull request most recent head 017f4ef. Consider uploading reports for the commit 017f4ef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   96.56%   96.54%   -0.03%     
==========================================
  Files           9        9              
  Lines        1106     1128      +22     
  Branches      103       99       -4     
==========================================
+ Hits         1068     1089      +21     
- Misses         38       39       +1     
Impacted Files Coverage Δ
...e/shared/src/main/scala/cats/parse/RadixNode.scala 95.31% <95.08%> (-4.69%) ⬇️
core/shared/src/main/scala/cats/parse/Parser.scala 96.58% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112d92a...017f4ef. Read the comment docs.

@regadas regadas left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I was puzzled with why would this fail 😄 but it seems that mima on master is also unhappy ... I'll take a look at this later today

@armanbilge

armanbilge commented Jan 27, 2022

Copy link
Copy Markdown
Member

Ah, this is because until #354 you were not checking MiMa on Scala 3 and #352 hadn't merged in the latest changes on main.

In my experience most MiMa failures that appear only on Scala 3 are harmless and only because of scala-garden/mima#682.

@johnynek

Copy link
Copy Markdown
Contributor

Thanks for chiming in @armanbilge

@regadas I can send a PR to filter the changes. Then you can merge master. You shouldn't have to fix my issues.

@regadas

regadas commented Jan 27, 2022

Copy link
Copy Markdown
Contributor Author

@armanbilge thx for the input!

@johnynek sorry didn't see your comment there's #361 that adds them.

@johnynek johnynek merged commit 828ff4b into typelevel:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants