Codecov Report

Merging #322 (c44e98e) into main (f309a8b) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   96.47%   96.28%   -0.20%     
==========================================
  Files           9        9              
  Lines        1049     1049              
  Branches       94       94              
==========================================
- Hits         1012     1010       -2     
- Misses         37       39       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f309a8b...c44e98e. Read the comment docs.

Hi @johnynek!

Wait so this means all users going forward not on 2.11 have to be on Java 11 right?

that's not the intent. We want to target JVM 8 (for now) regardless of the JVM version used to buid/publish the jar. The 2.11 check there exists because that scalac does not support the -release flag only the -target one.

I double checked and class files for the different scala versions have major version: 52

btw, this is required because the underlying plugin that we use for CI switched from 8 to 11 as default and we use it to publish the jars.

sorry for the latency on reviewing this. It looks right to me.

It would be interesting to think about adding some assertion that the built jars have the right class number, but I don't think we should block this (maybe a feature request for sbt-spiewak).