Skip to content

Fix scrollbar in the settings view #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saeedvaziry merged 2 commits into from
Dec 5, 2025
Merged

Fix scrollbar in the settings view #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9408eee
Fix scrollbar in the settings view
saeedvz Dec 5, 2025
65a84dc
audit fix
saeedvz Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions src/renderer/assets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,44 @@ body {
#title-bar button {
-webkit-app-region: no-drag;
}

::-webkit-scrollbar {
width: 8px; /* scrollbar width */
height: 8px; /* horizontal scrollbar height */
}

::-webkit-scrollbar-track {
background: transparent; /* track background */
}

::-webkit-scrollbar-thumb {
background-color: rgba(100, 100, 100, 0.5); /* thumb color */
border-radius: 10px; /* rounded ends */
border: 2px solid transparent; /* padding around thumb */
background-clip: content-box; /* ensures border doesn’t overlap thumb */
}

::-webkit-scrollbar-thumb:hover {
background-color: rgba(100, 100, 100, 0.7);
}

.scrollbar-hide {
scrollbar-width: none; /* Firefox */
-ms-overflow-style: none; /* IE 10+ */
}

.scrollbar-hide::-webkit-scrollbar {
display: none; /* Safari + Chrome */
}
Comment on lines +83 to +90

Copilot AI Dec 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .scrollbar-hide class duplicates the functionality of the existing .no-scrollbar class (lines 17-24). Both classes hide scrollbars using the same browser-specific properties. Consider removing this duplication and using the existing .no-scrollbar class instead, or remove the old class if you prefer the new naming convention.

Suggested change
.scrollbar-hide {
scrollbar-width: none; /* Firefox */
-ms-overflow-style: none; /* IE 10+ */
}
.scrollbar-hide::-webkit-scrollbar {
display: none; /* Safari + Chrome */
}

Copilot uses AI. Check for mistakes.

.react-flow__panel.react-flow__controls {
@apply mr-2 mb-6 !rounded-sm;
}

.react-flow__panel.react-flow__controls button:first-child {
@apply !rounded-t-sm;
}

.react-flow__panel.react-flow__controls button:last-child {
@apply !rounded-b-sm;
}
Comment on lines +92 to +102

Copilot AI Dec 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These react-flow CSS rules appear to be unrelated to the scrollbar fix and seem out of place in this Vue.js application. A search of the codebase found no usage of react-flow in any Vue, TypeScript, or JavaScript files. These styles should be removed unless there's a specific reason for including them (e.g., a planned feature addition).

Suggested change
.react-flow__panel.react-flow__controls {
@apply mr-2 mb-6 !rounded-sm;
}
.react-flow__panel.react-flow__controls button:first-child {
@apply !rounded-t-sm;
}
.react-flow__panel.react-flow__controls button:last-child {
@apply !rounded-b-sm;
}

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion src/renderer/components/Container.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
})

const classes = computed(() => {
return `w-full h-full ${props.class}`
return `w-full h-full overflow-y-auto ${props.class}`
})
</script>

Expand Down