Fix: Head type with union of empty and non-empty tuple#425
Merged
Conversation
Contributor
Author
|
@Beraliv This PR is also ready for review now! |
Beraliv
approved these changes
Dec 5, 2024
Beraliv
left a comment
Beraliv
left a comment
Collaborator
There was a problem hiding this comment.
Great work! No questions, everything looks clean, I'm going to merge it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Headdoesn't have any of the issues mentioned in this PR.However, there's one minor issue, when instantiated with a union of empty and non-empty tuple, it attaches an extraneous
| undefinedto the result. This PR addresses that issue and improves the test cases forHead.