Fix: Behaviour of Prettify when instantiated with functions#415
Merged
Beraliv merged 3 commits intoOct 28, 2024
Merged
Conversation
Collaborator
|
Hey @som-sm! Thank you for another contribution! I've let the pipelines run for all TypeScript versions, I'll re-visit your PRs with a more in-depth feedback |
Beraliv
reviewed
Oct 26, 2024
Beraliv
reviewed
Oct 26, 2024
Contributor
Author
|
@Beraliv I've updated the changeset, thanks again for reviewing the PR. |
Collaborator
|
@som-sm great work! I'm merging it now, will ping you when it's deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Currently the
Prettifytype when instantiated with functions returns{}(keyofwith functions yieldsnever), this PR fixes that by adding aFunctioncheck.