Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swiftwasm/JavaScriptKit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.51.0
Choose a base ref
...
head repository: swiftwasm/JavaScriptKit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.52.0
Choose a head ref
  • 10 commits
  • 32 files changed
  • 3 contributors

Commits on Apr 30, 2026

  1. Configuration menu
    Copy the full SHA
    1c107ad View commit details
    Browse the repository at this point in the history
  2. Merge pull request #732 from swiftwasm/kr/swift-format-ignore-generated

    BridgeJS: Add swift-format-ignore-file to generated Swift sources
    krodak authored Apr 30, 2026
    Configuration menu
    Copy the full SHA
    44ebc38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6eb6668 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #735 from swiftwasm/kr/nested-type-diagnostic

    BridgeJS: Support nested @js types inside structs and classes
    krodak authored Apr 30, 2026
    Configuration menu
    Copy the full SHA
    2dd870e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f90fe98 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #733 from swiftwasm/kr/struct-init-diagnostic

    BridgeJS: Diagnose struct initializer parameter order mismatch
    krodak authored Apr 30, 2026
    Configuration menu
    Copy the full SHA
    824c051 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2026

  1. BridgeJS: Fix optionals build error with Embedded Swift (#734)

    Remove @_spi(BridgeJS) from _BridgedAsOptional protocol and its
    Optional/JSUndefinedOr conformances so the conformances are visible
    in Embedded Swift mode. The underscore-prefixed protocol name already
    signals internal API, and all extension methods remain @_spi-gated.
    
    Fixes #689
    krodak authored May 4, 2026
    Configuration menu
    Copy the full SHA
    f8b2c96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43ed78f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2026

  1. Fix cross-thread JSString deinit by wrapping JSObject instead of raw ref

    JSString.Guts previously held a raw JavaScriptObjectRef and released it
    unconditionally on whatever thread ran deinit. In the multithreaded Wasm
    runtime each thread has its own JSObjectSpace, so releasing a ref on the
    wrong thread caused a TypeError crash (BugSnag: rc property of undefined).
    
    JSObject already handles this correctly by capturing ownerTid at init time
    and routing deinit through swjs_release_remote when destroyed off-thread.
    This change makes Guts hold a JSObject instead of a raw ref, delegating the
    correct cross-thread release behaviour to the existing JSObject.deinit path.
    
    Adds a regression test testDeinitJSStringOnDifferentThread that reproduces
    the crash deterministically: it forces JS ref allocation on the main thread
    via asInternalJSRef(), then drops the last reference on a worker thread.
    
    Fixes the crash seen in v292745-rc4 after upgrading to JavaScriptKit 0.50.2.
    
    https://claude.ai/code/session_01Qhg5GLXZYNJtH63Gs1SwJH
    claude committed May 6, 2026
    Configuration menu
    Copy the full SHA
    d3f96f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ea916b View commit details
    Browse the repository at this point in the history
Loading