Node alpine as base image#750
Open
qkudev wants to merge 2 commits into
Open
Conversation
Changes base image from `node:18.16.0` to `node:18.16.0-alpine`. This change dramatically affects docker image size: down from 1.21gb to 178mb. Adds "production" as default for build arg `NODE_ENV`.
deftdawg
reviewed
Nov 15, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM node:18.16.0 | |||
| FROM node:18.16.0-alpine | |||
There was a problem hiding this comment.
FROM node:18.20-alpine
I suggest bumping to this, since it still seems to work ok and has ~330 security warnings when you run it through grype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker image: use alpine as base image
Changes base image from
node:18.16.0tonode:18.16.0-alpine.This change dramatically affects docker image size: down from 1.21gb to 178mb.
Adds "production" as default for build arg
NODE_ENV.Also adds a "how to configure docker image" section to
README.MD(#727).