Skip to content

Question about converting Offset to accept long instead of int #532

@atdimitrov

Description

@atdimitrov

Hello.

I have a use case where I have to generate select query with offset bigger that int.MaxValue. As said in #298 int is sufficient for almost all cases, but not all. While I mostly agree with that statement for Limit, because it is rather rare for someone to attempt to read over 2 billion rows at once, the case is rather different when it comes to Offset.

Apart from the slightly higher memory usage, I don't see any disadvantages to making this API take long instead of int. Of course I'm don't have domain knowledge about the library, so I may be missing something. Do you, guys, see anything that would make such a change unfeasable or undesirable?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions