Exclusively use go1.20 multierrors#127
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 12 12
Lines 484 484
=======================================
Hits 479 479
Misses 4 4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
camdencheek
force-pushed
the
cc/multierror
branch
2 times, most recently
from
fb2473d to
b7c57e5
Compare
bobheadxi
approved these changes
Jan 19, 2024
camdencheek
force-pushed
the
cc/multierror
branch
from
b7c57e5 to
5eb68f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
go.uber.org/multierrorin favor of the multierror functionality included in go 1.20.As a consequence, this removes support for go versions earlier than go 1.20. In order to maintain the standard "two minor versions" support policy, this change will not be released (likely in a 1.0 version) until go 1.22 is released.