Skip to content

feat(iter): Added context accepting variants of Map & ForEach #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkoehl05 wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(iter): Added context accepting variants of Map & ForEach #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
60f3996
initial changes
May 15, 2023
a22d62e
using contextpool over errgroup
May 15, 2023
57ae9ca
checking input size
May 15, 2023
722e19d
removing declarations
May 15, 2023
e9a88bf
Moving function
May 15, 2023
c6581d3
moving new functions down
May 15, 2023
4a15de5
renaming outer context
May 15, 2023
3ae45b6
splitting init
May 15, 2023
11cbc39
added comments
May 15, 2023
1d04c68
testing Map
May 15, 2023
d71cc05
tests
May 15, 2023
2f570b7
Renaming MapErrCtx to MapCtx
May 31, 2023
bba9127
reimplemented Map with MapCtx
May 31, 2023
825d1df
Fixing comment
May 31, 2023
296e00b
Fixing lint issues
Jun 1, 2023
9018777
removed octx
Jun 1, 2023
08c699d
fixing naming
Jun 1, 2023
56a8612
syncing
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added comments
  • Loading branch information
Ron Koehler committed May 15, 2023
commit 11cbc39ab9c46ae486cb8e4393e5abaab56cd5ef
22 changes: 17 additions & 5 deletions iter/iter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,32 @@ func (iter Iterator[T]) ForEachIdx(input []T, f func(int, *T)) {
})
}

func ForEachIdxCtx[T any](octx context.Context, input []T, f func(context.Context, int, *T) error) error {
return Iterator[T]{}.ForEachIdxCtx(octx, input, f)
}

// ForEachCtx is the same as ForEach except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func ForEachCtx[T any](octx context.Context, input []T, f func(context.Context, *T) error) error {
return Iterator[T]{}.ForEachCtx(octx, input, f)
}

// ForEachCtx is the same as ForEach except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func (iter Iterator[T]) ForEachCtx(octx context.Context, input []T, f func(context.Context, *T) error) error {
return iter.ForEachIdxCtx(octx, input, func(ctx context.Context, _ int, input *T) error {
return f(ctx, input)
})
}

// ForEachIdxCtx is the same as ForEachIdx except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func ForEachIdxCtx[T any](octx context.Context, input []T, f func(context.Context, int, *T) error) error {
return Iterator[T]{}.ForEachIdxCtx(octx, input, f)
}

// ForEachIdxCtx is the same as ForEachIdx except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func (iter Iterator[T]) ForEachIdxCtx(octx context.Context, input []T, f func(context.Context, int, *T) error) error {
if iter.MaxGoroutines == 0 {
// iter is a value receiver and is hence safe to mutate
Expand All @@ -99,7 +111,7 @@ func (iter Iterator[T]) ForEachIdxCtx(octx context.Context, input []T, f func(co
return err
}
}
return nil
return ctx.Err() // nil if the context was never cancelled
}

runner := pool.New().
Expand Down
6 changes: 6 additions & 0 deletions iter/map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,16 @@ func (m Mapper[T, R]) MapErr(input []T, f func(*T) (R, error)) ([]R, error) {
return res, errs
}

// MapErrCtx is the same as MapErr except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func MapErrCtx[T, R any](octx context.Context, input []T, f func(context.Context, *T) (R, error)) ([]R, error) {
Comment thread
rkoehl05 marked this conversation as resolved.
Outdated
return Mapper[T, R]{}.MapErrCtx(octx, input, f)
}

// MapErrCtx is the same as MapErr except it also accepts a context
// that it uses to manages the execution of tasks.
// The context is cancelled on task failure and the first error is returned
func (m Mapper[T, R]) MapErrCtx(octx context.Context, input []T, f func(context.Context, *T) (R, error)) ([]R, error) {
var (
res = make([]R, len(input))
Expand Down