Bump discard requirement#6488
Merged
Merged
Conversation
Discard v2 slightly changes how transactions and callbacks interact to be more consistent with how they work with operations like delete in ActiveRecord. I don't know if we depend on that behaviour, but we should lock ourselves to the more correct behaviour, in case it matters.
github-actions
Bot
added
the
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 992 992
Lines 20846 20846
=======================================
Hits 18695 18695
Misses 2151 2151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adammathys
approved these changes
Jun 8, 2026
tvdeyen
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard v2 slightly changes how transactions and callbacks interact to be more consistent with how they work with operations like delete in ActiveRecord. I don't know if we depend on that behaviour, but we should lock ourselves to the more correct behaviour, in case it matters.