MNT: Update dtypes to reflect numpy namespace refactor#27082
Closed
mtsokol wants to merge 2 commits into
Closed
Conversation
mtsokol
changed the title
Micky774
changed the title
mtsokol
force-pushed
the
update-numpy-namespace-refactor-part-3
branch
from
fffe617 to
8f64bb1
Compare
rgommers
approved these changes
Aug 28, 2023
Contributor
|
Argh, reviewed twice I see now - I thought this was new. Scikit-learn devs: I suggest to merge these cleanup PRs from @mtsokol rapidly; it helps avoid failures when we merge the corresponding cleanups in numpy's |
Member
Member
|
Sorry I did not see this PR indeed before I opened #27190, which started as a single fix and ended up as "let's try to fix as many numpy dev and scipy dev issues while I am at it". I think this can be closed. AFAICT the changes in
|
Member
|
I am going to close this one, but feel free to reopen if I missed something! |
Contributor
Author
@lesteve It's just a detail, to match other entires (first canonical name str, then sized alias str). I think it can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Here's a PR with follow-up work related to numpy/numpy#24376 changes. Basically, I update all items that are being removed in Part 3 of "main namespace refactor" PRs.