Skip to content

Enhance sourceMapIncludeSources option#4170

Open
ntkme wants to merge 3 commits into
sass:mainfrom
sass-contrib:source-map-include-sources
Open

Enhance sourceMapIncludeSources option#4170
ntkme wants to merge 3 commits into
sass:mainfrom
sass-contrib:source-map-include-sources

Conversation

@ntkme
Copy link
Copy Markdown
Contributor

@ntkme ntkme commented Dec 27, 2025

sass/dart-sass#2712

This PR add new supported values for sourceMapIncludeSources:

  • 'auto' - same as undefined
  • 'always' - same as true
  • 'never' - same as false

The old boolean values true and false are deprecated and will be removed.

Copy link
Copy Markdown
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to deprecate passing true and false to sourceMapIncludeSources, which means this needs to be a full proposal document with an open comment period.

Comment thread EMBEDDED_PROTOCOL_CHANGELOG.md Outdated
Comment thread js-api-doc/options.d.ts
@ntkme ntkme force-pushed the source-map-include-sources branch 4 times, most recently from f84c560 to de9cd35 Compare January 6, 2026 03:45
@ntkme ntkme force-pushed the source-map-include-sources branch 2 times, most recently from 696e9ec to 096ff75 Compare January 21, 2026 23:48
@ntkme ntkme force-pushed the source-map-include-sources branch 2 times, most recently from 1677808 to ba0388e Compare January 29, 2026 02:52
Comment thread spec/deprecations.yaml Outdated
Comment thread EMBEDDED_PROTOCOL_CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to include the proposal's changes for importer.d.ts.md.

Comment thread spec/js-api/options.d.ts.md Outdated
@ntkme ntkme force-pushed the source-map-include-sources branch 2 times, most recently from dfaaaaf to 85de7f0 Compare May 23, 2026 01:58
@ntkme ntkme force-pushed the source-map-include-sources branch from 490e733 to b668098 Compare May 23, 2026 02:01
@ntkme ntkme requested a review from nex3 May 23, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants