Modernize dependencies and gem configuration#26
Merged
Merged
Conversation
- Update vendored simdjson from v0.5.0 to v4.6.1 - Raise C++ standard from C++11 to C++17 - Raise minimum Ruby from 2.6 to 3.2 - Update CI matrix to Ruby 3.2, 3.3, 3.4, 4.0 with actions/checkout@v4 - Modernize gemspec: explicit file list, metadata, move dev deps to Gemfile - Update RuboCop to 1.x with plugins syntax - Fix include order in simdjson_ruby.cpp (simdjson.h before ruby.h) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Based on the fix by Watson1978 in PR #24. Ruby 3.0+ no longer includes $(optflags) in CXXFLAGS automatically, causing simdjson to compile without -O2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
simdjson C++ library
lemire/simdjson→simdjson/simdjson(upstream migration)simdjson.hmust now be included beforeruby.hto avoidsnprintfmacro conflictPerformance fix
$(optflags)inCXXFLAGSautomatically, causing simdjson to compile without-O2. Adding$(optflags) $(debugflags)restores proper optimization.Ruby / Gem
required_ruby_version:>= 2.6→>= 3.2git ls-fileswithDir.glob, removed deadbindir/executables, addedrubygems_mfa_requiredmetadataCI / Tooling
actions/checkout@v2→@v4[2.6, 2.7, 3.0]→[3.2, 3.3, 3.4, 4.0]require:→plugins:,NewCops: disable)Test plan
bundle exec rake(clobber → compile → test) — 10 tests, 0 failuresbundle exec rubocop --fail-level=W— 0 offensesbundle exec rake bench— runs without crashesgem build simdjson.gemspec— produces correct gem with only necessary files🤖 Generated with Claude Code