Minor cs-fixer change and add count to phpstan.neon#93
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I some recent cs-fixer release it seems that it wants and/or
&&||to be at the start of continuation lines of complex logic conditions. This little change fixescomposer cs-fixer.I updated all the
require-devdependencies to show what minor version they are currently at, because that is what is really used in CI and what we know passes.Added
countinphpstan.neonignoreErrors. That is a bit of extra validation, in case someone accidentally adds more code that happens to have the same problem - the CI will fail becausecountwill b2and so the person will know and will have to think about it.