chore(deps): phpstan major version 2#124
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 97.70% 97.72% +0.02%
==========================================
Files 1 1
Lines 174 176 +2
==========================================
+ Hits 170 172 +2
Misses 4 4 ☔ View full report in Codecov by Sentry. |
phil-davis
commented
Dec 2, 2024
Comment on lines
+146
to
+147
| 'http' => 80, | ||
| 'https' => 443, |
Contributor
Author
There was a problem hiding this comment.
Note:
parse_url always returns $parts['port'] as an int (if it exists).
So we should do strict comparison below at line 150, and compare integers.
phpstan v2 wants strict === comparisons:
------ ---------------------------------------------
Line lib/functions.php
------ ---------------------------------------------
150 Loose comparison via "==" is not allowed.
🪪 equal.notAllowed
💡 Use strict comparison via "===" instead.
------ ---------------------------------------------
staabm
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.