WIP: use RNG in SigningKey#742
Draft
hko-s wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explore how low-level signing functions could access an RNG where appropriate.
In this PR, that's used in src/crypto/ecdsa.rs to call
sign_prehash_with_rnginstread ofsign_prehash.To be able to hand an RNG into that function, I've extended the SigningKey trait (and then adjusted the rest of rPGP to the point where it mostly compiles).
I don't love how much noise this adds, but at the same time, I understand that this is a slightly more robust way to do ECDSA.
And separately, an RNG is also needed for the low level signing operation in #667 (draft-ietf-openpgp-persistent-symmetric-keys).