Allow overriding external database name in Nominatim chart#141
Merged
Conversation
Owner
|
@frascu Thax for the PR Are you sure this will work? Nominatim was always expecting that the database is |
Contributor
Author
|
It works because the connection is defined via the {{- define "nominatim.databaseDSN" -}}
pgsql:dbname={{ include "nominatim.databaseName" . }};host={{ include "nominatim.databaseHost" . }};port={{ include "nominatim.databasePort" . }};user={{ include "nominatim.databaseUser" . }};password={{ include "nominatim.databasePassword" . }}
{{- end }}As you can see, the database name is included in the DSN and therefore correctly used by Nominatim. I tested this setup on the same Kubernetes cluster with the same PostgreSQL instance, using multiple databases with different names, and it worked as expected. |
robjuz
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows specifying a custom name for an external database in the Nominatim Helm chart.
Main changes:
nominatim.databaseNamefunction to return:.Values.postgresql.enabled = true)Values.externalDatabase.databaseNameif using an external database (.Values.postgresql.enabled = false)externalDatabase.databaseNameparameter to configure the external database name:Benefits: