-
Notifications
You must be signed in to change notification settings - Fork 120
[DONE]: Translate Your First Component
#488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
50d6770
[your-first-component] translate overview, components
eihabkhan 23c8a28
[your-first-component] translate define component
eihabkhan b51c092
translate using a component and what the browser sees
eihabkhan d80e707
translate remainder of the page
eihabkhan 02c4805
undo rtl changes to layout page
eihabkhan 76f9912
fix typo at line 7
eihabkhan a0bdf54
#1 From L1 to L120
AhmedBaset 1beffed
#2 From 120 to 215
AhmedBaset 45d9e4c
#3
AhmedBaset File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix typo at line 7
- Loading branch information
commit 76f9912c6b06b6749b3605cd847c51e1cc1afa0f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A7med3bdulBaset Looks great, thanks for the corrections.