Skip to content

Improve GroupBy generics#1138

Merged
Shredder121 merged 1 commit into
masterfrom
i1112
Jan 31, 2015
Merged

Improve GroupBy generics#1138
Shredder121 merged 1 commit into
masterfrom
i1112

Conversation

@timowest
Copy link
Copy Markdown
Member

@timowest timowest commented Jan 25, 2015

Fixes #1112

@timowest
Copy link
Copy Markdown
Member Author

timowest commented Jan 31, 2015

@Shredder121 Is this good to merge? As you suggested, Comparable constraints should be also changed in other places, but that can be maybe done via another PR?

@Shredder121
Copy link
Copy Markdown
Member

Shredder121 commented Jan 31, 2015

Yes, this is good to merge.
And yes, I already did some work, to see how to format it well.

Shredder121 added a commit that referenced this pull request Jan 31, 2015
@Shredder121
Merge pull request #1138 from querydsl/i1112
be6e55b 
Improve GroupBy generics
@Shredder121 Shredder121 merged commit be6e55b into master Jan 31, 2015
@Shredder121 Shredder121 deleted the i1112 branch January 31, 2015 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adjustment suggestions to GroupBy generics

2 participants

@timowest @Shredder121